Merge pull request #604 from FSMaxB/fix-accidental-deletion-of-all-pa…

…sswords Fix accidental deletion of entire passwordstore
IJHack · Jan 28, 2023 · f66720d · f66720d
2 parents bc2c04c + 92a724d
commit f66720d
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp
@@ -640,6 +640,14 @@ void MainWindow::addPassword() {
  * sure.
  */
 void MainWindow::onDelete() {
+  QModelIndex currentIndex = ui->treeView->currentIndex();
+  if (!currentIndex.isValid()) {
+    // This fixes https://github.com/IJHack/QtPass/issues/556
+    // Otherwise the entire password directory would be deleted if
+    // nothing is selected in the tree view.
+    return;
+  }
+
   QFileInfo fileOrFolder =
       model.fileInfo(proxyModel.mapToSource(ui->treeView->currentIndex()));
   QString file = "";