-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfixes #413
Bugfixes #413
Conversation
It causes a huge amount of completely irrelevant warnings on that compiler.
No idea why "or" would work at all, but definitely fails to compile on MSVC.
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
=========================================
- Coverage 6.46% 5.87% -0.59%
=========================================
Files 39 39
Lines 2585 2586 +1
=========================================
- Hits 167 152 -15
- Misses 2418 2434 +16
Continue to review full report at Codecov.
|
src/mainwindow.cpp
Outdated
@@ -411,6 +411,9 @@ void MainWindow::config() { | |||
this->show(); | |||
|
|||
updateProfileBox(); | |||
// For freshStart, proxyModel is not yet configured | |||
// and maniplating it will assert | |||
if (!freshStart) | |||
ui->treeView->setRootIndex(proxyModel.mapFromSource( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please indent the line after the if. Otherwise this looks very confusing.
mapFromSource can't be called when the proxyModel has no source model set yet.
04c9ca2
to
68490dc
Compare
No description provided.