Fix character encoding issues for non-UTF-8 locales. #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we (most sensibly) encode text as UTF-8 before encrypting we should assume that the password files contain UTF-8 when decrypting, instead of the current locale encoding. This is the biggest issue on Windows, since it doesn't even officially support locales with UTF-8 encoding. For compatibility, detect if the data is not valid UTF-8 and fall back to Qt's BOM based approach, which provides support for UTF-16 and falls back to current locale encoding. Fixes issue IJHack#412
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
=========================================
- Coverage 7.25% 7.23% -0.02%
=========================================
Files 41 41
Lines 2662 2666 +4
=========================================
Hits 193 193
- Misses 2469 2473 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we (most sensibly) encode text as UTF-8 before
encrypting we should assume that the password files
contain UTF-8 when decrypting, instead of the current
locale encoding.
This is the biggest issue on Windows, since it doesn't
even officially support locales with UTF-8 encoding.
For compatibility, detect if the data is not valid UTF-8
and fall back to Qt's BOM based approach, which provides
support for UTF-16 and falls back to current locale encoding.
Fixes issue #412