Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patient Registration 2.x Review #205

Closed
11 tasks done
sfount opened this issue Mar 23, 2016 · 2 comments · Fixed by #667
Closed
11 tasks done

Patient Registration 2.x Review #205

sfount opened this issue Mar 23, 2016 · 2 comments · Fixed by #667
Labels
client module Refactor

Comments

@sfount
Copy link
Contributor

sfount commented Mar 23, 2016 •
edited by jniles

Patient registration has been updated to the 2.x build using the latest technology stack; this is an issue to track the review/ refactor process through completion (PRODUCTION READY)

Form Validation

  • Refactor to use the latest form validation techniques; this includes ng-messages etc.

Testing

  • E2E tests updated to latest standard (Page objects etc.)
  • Integration tests for /patients route uses latest standards

Error Handling

  • Module displays errors globally (handles errors globally)
  • /patients route throws meaningful errors to the latest standard

Server Side API

  • Binary UUIDs used for all relevant tables (patients, debtors)
  • Transactions are used anywhere with multiple writes

Code

  • Code is documented producing JSDoc page
  • Service architecture is used to the latest standard (complete separation of concerns)
  • Database is verified with tests to be strict on rejecting incorrect values
  • Dates are handled uniformly to the latest standards (+tested)

Any discussion relevant to patient registration can be commented below - anything that has been missed will be added into the issue. Once these things have been verified the module will be reviewed and marked as complete.
@sfount sfount added this to the 2.x Process milestone Mar 23, 2016
@sfount sfount mentioned this issue Mar 29, 2016
Merged
1 task
@jniles jniles modified the milestones: Medical/Hospital Impementation, 2.x Process Jun 11, 2016
@jniles
Copy link
Collaborator

jniles commented Jun 15, 2016 •
edited

Two issues of interest before declaring this module done:

  1. The date input should be a datepicker. DONE
  2. The location inputs do not reload the enterprise's location, now that the page no longer navigates away. This is a problem with the bhLocationSelect rather than the page itself, but must be resolved before shipping.

@jniles
Copy link
Collaborator

jniles commented Jun 15, 2016

Also has some form validation issues, especially on the optional information.

jniles referenced this issue in jniles/bhima Jun 20, 2016
@jniles
refactor(patient reg): finish 2.x review criteria
235b2e2 
This commit cleans up the Patient Registrations page, attempting to
finalize the 2.x criteria for patient registrations and complete them
once and for all.

Significant Changes:
 1. The date input has been changed to a `uib-datepicker-popup`.
 Unfortunately, the datepicker doesn't actually validate the input, only
 the datepicker popup's calendar.  See
 angular-ui/bootstrap#4664 for more
 information.  Therefore, I wrote a custom date `$validator`,
 `bhDateValidator` to ensure that dates are in the valid range.

 2. The patient registration pages uses `bhSubmit` to regulate form
 submission.

 3. Every single unused `id` was removed from the HTML inputs.

This commit should be reviewed to see if it may close the Patient
Registration review issue #205.
@jniles jniles mentioned this issue Jun 20, 2016
Merged
4 tasks
jniles referenced this issue in jniles/bhima Jun 20, 2016
@jniles
refactor(patient reg): finish 2.x review criteria
b927533 
This commit cleans up the Patient Registrations page, attempting to
finalize the 2.x criteria for patient registrations and complete them
once and for all.

Significant Changes:
 1. The date input has been changed to a `uib-datepicker-popup`.
 Unfortunately, the datepicker doesn't actually validate the input, only
 the datepicker popup's calendar.  See
 angular-ui/bootstrap#4664 for more
 information.  Therefore, I wrote a custom date `$validator`,
 `bhDateValidator` to ensure that dates are in the valid range.

 2. The patient registration pages uses `bhSubmit` to regulate form
 submission.

 3. Every single unused `id` was removed from the HTML inputs.

This commit should be reviewed to see if it may close the Patient
Registration review issue #205.
jniles referenced this issue in jniles/bhima Jun 21, 2016
@jniles
refactor(patient reg): finish 2.x review criteria
4ffb8b3 
This commit cleans up the Patient Registrations page, attempting to
finalize the 2.x criteria for patient registrations and complete them
once and for all.

Significant Changes:
 1. The date input has been changed to a `uib-datepicker-popup`.
 Unfortunately, the datepicker doesn't actually validate the input, only
 the datepicker popup's calendar.  See
 angular-ui/bootstrap#4664 for more
 information.  Therefore, I wrote a custom date `$validator`,
 `bhDateValidator` to ensure that dates are in the valid range.

 2. The patient registration pages uses `bhSubmit` to regulate form
 submission.

 3. Every single unused `id` was removed from the HTML inputs.

This commit should be reviewed to see if it may close the Patient
Registration review issue #205.
jniles referenced this issue in jniles/bhima Jun 21, 2016
@jniles
refactor(patient reg): finish 2.x review criteria
eb73e4c 
This commit cleans up the Patient Registrations page, attempting to
finalize the 2.x criteria for patient registrations and complete them
once and for all.

Significant Changes:
 1. The date input has been changed to a `uib-datepicker-popup`.
 Unfortunately, the datepicker doesn't actually validate the input, only
 the datepicker popup's calendar.  See
 angular-ui/bootstrap#4664 for more
 information.  Therefore, I wrote a custom date `$validator`,
 `bhDateValidator` to ensure that dates are in the valid range.

 2. The patient registration pages uses `bhSubmit` to regulate form
 submission.

 3. Every single unused `id` was removed from the HTML inputs.

This commit should be reviewed to see if it may close the Patient
Registration review issue #205.
sfount pushed a commit that referenced this issue Jun 22, 2016
@jniles @sfount
refactor(patient reg): finish 2.x review criteria (#511)
054425e 
This commit cleans up the Patient Registrations page, attempting to
finalize the 2.x criteria for patient registrations and complete them
once and for all.

Significant Changes:
 1. The date input has been changed to a `uib-datepicker-popup`.
 Unfortunately, the datepicker doesn't actually validate the input, only
 the datepicker popup's calendar.  See
 angular-ui/bootstrap#4664 for more
 information.  Therefore, I wrote a custom date `$validator`,
 `bhDateValidator` to ensure that dates are in the valid range.

 2. The patient registration pages uses `bhSubmit` to regulate form
 submission.

 3. Every single unused `id` was removed from the HTML inputs.

This commit should be reviewed to see if it may close the Patient
Registration review issue #205.
jniles referenced this issue in jniles/bhima Jun 27, 2016
@jniles
refactor(patient reg): finish 2.x review criteria (#511)
e00bdf6 
This commit cleans up the Patient Registrations page, attempting to
finalize the 2.x criteria for patient registrations and complete them
once and for all.

Significant Changes:
 1. The date input has been changed to a `uib-datepicker-popup`.
 Unfortunately, the datepicker doesn't actually validate the input, only
 the datepicker popup's calendar.  See
 angular-ui/bootstrap#4664 for more
 information.  Therefore, I wrote a custom date `$validator`,
 `bhDateValidator` to ensure that dates are in the valid range.

 2. The patient registration pages uses `bhSubmit` to regulate form
 submission.

 3. Every single unused `id` was removed from the HTML inputs.

This commit should be reviewed to see if it may close the Patient
Registration review issue #205.
@jniles jniles mentioned this issue Aug 25, 2016
Merged
4 tasks
jniles referenced this issue in jniles/bhima Jan 30, 2017
@jniles
Merge pull request #205 from mbayopanda/registry_action
61e1303 
Add dropdown action in bhima registries
bors bot added a commit that referenced this issue Jul 13, 2017
@bors
Merge #1826 #1827
84405c0 
1826: Correct some lint errors r=jniles

This PR fixes some errors of eslint to make sure the repository still clean
Thank you for contributing!

Before submitting this pull request, please verify that you have:
 - [x] Run your code through ESLint.  [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md).
 - [x] Run integration tests.
 - [x] Run end-to-end tests.
 - [x] Accurately described the changes your are making in this pull request.

For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against.

Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application.  Thanks!


1827: Update chai-as-promised to the latest version 🚀 r=jniles


## Version **7.1.0** of [chai-as-promised](https://github.com/domenic/chai-as-promised) just got published.

<table>
  <tr>
    <th align=left>
      Dependency
    </td>
    <td>
      chai-as-promised
    </td>
  </tr>
  <tr>
    <th align=left>
      Current Version
    </td>
    <td>
      6.0.0
    </td>
  </tr>
  <tr>
    <th align=left>
      Type
    </td>
    <td>
      devDependency
    </td>
  </tr>
</table>

The version **7.1.0** is **not covered** by your **current version range**.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of chai-as-promised.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


---


<details>
<summary>Release Notes</summary>
<strong>7.1.0</strong>

<p>Fixes Chai's proxy protection for property assertions (when using Chai v4 or higher). (<a href="https://urls.greenkeeper.io/meeber" class="user-mention">@meeber</a>, <a href="https://urls.greenkeeper.io/domenic/chai-as-promised/pull/205" class="issue-link js-issue-link" data-url="chaijs/chai-as-promised#205" data-id="235023818" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#205</a>)</p>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 8 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/domenic/chai-as-promised/commit/4c2d628de0be636077e669c3aeb7d3a87ce21971"><code>4c2d628</code></a> <code>7.1.0</code></li>
<li><a href="https://urls.greenkeeper.io/domenic/chai-as-promised/commit/248810a508b94ca47473b9385aea2f9f151168a1"><code>248810a</code></a> <code>Fix proxies for property assertions (#205)</code></li>
<li><a href="https://urls.greenkeeper.io/domenic/chai-as-promised/commit/a60bf923d25f464a36a3d6ff4958137c397e1336"><code>a60bf92</code></a> <code>7.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/domenic/chai-as-promised/commit/a92de93caea9803c11736a1208234d3be7d3a42c"><code>a92de93</code></a> <code>Convert tests away from CoffeeScript</code></li>
<li><a href="https://urls.greenkeeper.io/domenic/chai-as-promised/commit/ce2d4cb04bad5b2ea10f4bd5b74fdcc54ab89227"><code>ce2d4cb</code></a> <code>Add a note about using other Chai plugins</code></li>
<li><a href="https://urls.greenkeeper.io/domenic/chai-as-promised/commit/e8021e44021e769e1eed4dfdd85856b365287870"><code>e8021e4</code></a> <code>Update for Chai v4.0</code></li>
<li><a href="https://urls.greenkeeper.io/domenic/chai-as-promised/commit/16dde11e8d566771681dd6c39fd28716c9de69fa"><code>16dde11</code></a> <code>Various cleanups and updates</code></li>
<li><a href="https://urls.greenkeeper.io/domenic/chai-as-promised/commit/0dfd21181193bb1fd46664b35893bac75df6b004"><code>0dfd211</code></a> <code>Test all supported versions of Chai; assume Node v4+</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/domenic/chai-as-promised/compare/b2cfbdc71360dad1faaa29f64bcc8ba54819084e...4c2d628de0be636077e669c3aeb7d3a87ce21971">full diff</a></p>
</details>

<details>
  <summary>Not sure how things should work exactly?</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>


---


Your [Greenkeeper](https://greenkeeper.io) Bot 🌴
bors bot added a commit that referenced this issue Aug 23, 2018
@bors @greenkeeper
Merge #3069
f23ab90 
3069: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot]




## Version **1.92.7** of **snyk** was just published.

<table>
  <tr>
    <th align=left>
      Dependency
    </th>
    <td>
      <a target=_blank href=https://github.com/snyk/snyk>snyk</a>
    </td>
  </tr>
  <tr>
      <th align=left>
       Current Version
      </th>
      <td>
        1.92.3
      </td>
    </tr>
  <tr>
    <th align=left>
      Type
    </th>
    <td>
      dependency
    </td>
  </tr>
</table>



The version **1.92.7** is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of snyk.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


---


<details>
<summary>Release Notes</summary>
<strong>v1.92.7</strong>

<h2><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.92.6...v1.92.7">1.92.7</a> (2018-08-23)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>don't throw error if callback provided (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/6938cf2">6938cf2</a>)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 11 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/6eeface5ea0b9e976ef658408c990b80fb276aba"><code>6eeface</code></a> <code>Merge pull request #205 from snyk/test/tap-update</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/0b3960489faf54e2e26617f26445b01ee96c47db"><code>0b39604</code></a> <code>test: adjust patch test fixture</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/6938cf2ccae01e33f2c3c7b97b26926202bc2797"><code>6938cf2</code></a> <code>fix: don't throw error if callback provided</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/64d9ad28c24bc822cb63bce10e12b2df6fc813be"><code>64d9ad2</code></a> <code>test: update tap version</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/acfab6d3f493ede14c37bfd9a2165f69008e96f5"><code>acfab6d</code></a> <code>Merge pull request #204 from snyk/fix/bump-nuget-plugin</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/ff819a58f793457dc850f1c4d5b4173ba394b079"><code>ff819a5</code></a> <code>test: upgrade tap for better dev deps</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/6b7dd3da344deba8d0d83443d546d14762605d41"><code>6b7dd3d</code></a> <code>fix: bump snyk-nuget-plugin for a more modern zip library</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/1b0ca39bcdb1f0f034020211fa945f0b9a7d038a"><code>1b0ca39</code></a> <code>Merge pull request #202 from snyk/fix/bump-docker-plugin</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/c583e340033ebac626629468978679df4f871015"><code>c583e34</code></a> <code>Merge pull request #203 from snyk/fix/explicit-files-instead-of-ignores</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/3087b28273493e3b091e32473d2ed22e616773da"><code>3087b28</code></a> <code>fix: explicitly include files in npm package</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/32327c5466227d18d347c40a26c7f8c3e23fc973"><code>32327c5</code></a> <code>fix: bump snyk-docker-plugin for smaller footprint</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/4fee53e3cfc792cda73c1f044dee6743fb0a781e...6eeface5ea0b9e976ef658408c990b80fb276aba">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client module Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: patient registration jniles/bhima
2 participants
@jniles @sfount