Made Icons In Footer Functional to Access Socials | Closes Issue #12 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhokladrijaa you have removed the about company section, |
re-added about me
Hi, I have fixed it, kindly check |
Yash-g2310
reviewed
Jan 5, 2025
There was a problem hiding this comment.
@dhokladrijaa also make sure to bring back the company name and logo so that i can merge the code
Yash-g2310
reviewed
Jan 5, 2025
| <div class="hasell"> | ||
| <div class="umm"><img src="logo1" id="logo2"></div> | ||
| <div id="sell">Easysell</div> | ||
| </div> |
There was a problem hiding this comment.
here please, there was no need to remove this code
|
@dhokladrijaa please correct it by today or I'll be closing the PR. |
|
Also solve the merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #12
Type of Change
Description of Change
social links now redirect to the homepage of the social sites, the location opens google maps and email opens a draft to the given email.
Implementation Details
by updating the
hrefattributes in the footer's<a>tags and amailto:link for the emailDemo
Landing_Page.-.Google.Chrome.2024-12-18.01-29-28.mp4