Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added about us and our ethos text #72

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

Moon-deity
Copy link
Collaborator

Related Issue

Closes #26 number

Type of Change

Put x inside the square bracket to specify what type of change your PR is:

  • New Feature
  • Bug Fix
  • Code Refactor
  • Documentation Update
  • Other (please specify):

Description of Change

added about us and our ethos text

Implementation Details

changed aboutus.html and aboutus.css and created changeaboutcontent.js

Demo

Screenshot 2024-12-24 004305
Screenshot 2024-12-24 004443

@sasmitaditya13
Copy link
Collaborator

@Yash-g2310 please check the responsiveness of the changes made.

Copy link
Collaborator

@Yash-g2310 Yash-g2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Moon-deity
the changes are good, just a couple of things,

  1. see the correct font weight of the headings from figma
  2. in mobile view the alignment of the description is center not left
    image
    please make these 2 changes here is the figma link

@Moon-deity
Copy link
Collaborator Author

@Yash-g2310
In mobie view alignment of text is center but it seems on the left because larger words are not fitting properly (you can see the screenshot I added above, it's of the same page in mobile view)

@Yash-g2310
Copy link
Collaborator

@Moon-deity
image
when the text would be centered it would look something like this
image
but there is not text align property currently please check!!

@Moon-deity
Copy link
Collaborator Author

@Yash-g2310
Please check it now

@Yash-g2310
Copy link
Collaborator

Changes are nice we would be merging it soon

@sasmitaditya13 sasmitaditya13 merged commit 8f4e1e1 into IMGIITRoorkee:main Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the product description and our ethos in About Us page.
3 participants