Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor codebase #24

Open
rbpatt2019 opened this issue Jan 25, 2022 · 0 comments
Open

Refactor codebase #24

rbpatt2019 opened this issue Jan 25, 2022 · 0 comments
Assignees
@rbpatt2019
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@rbpatt2019
Copy link
Collaborator

While working through some bugfixes
(see #23),
I came to the conclusion that a refactor of the codebase is necessary.
The current implementation is clunky,
and makes units hard to isolate for testing and fixing purposes.

This issuee is to centralise tracking for progress on this topic.
@rbpatt2019 rbpatt2019 added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 25, 2022
@rbpatt2019 rbpatt2019 self-assigned this Jan 25, 2022
rbpatt2019 added a commit that referenced this issue Feb 15, 2022
@rbpatt2019
refactor(jaccard.py): correctly check for None
8b4091f 
It is more pythonic to check for None with `if x is None`.

See #24.
rbpatt2019 added a commit that referenced this issue Feb 15, 2022
@rbpatt2019
refactor(jaccard.py): correctly check for None
22e0d70 
It is more pythonic to check for None with `if x is None`.

See #24.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbpatt2019 rbpatt2019

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rbpatt2019