Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular imports due to autopep8 formatting in digital device twins #329

Closed
TomTomRixRix opened this issue Jun 28, 2024 · 0 comments
Closed
Assignees
Labels
bug Something isn't working hacking week

Comments

@TomTomRixRix
Copy link
Collaborator

Describe the bug
Autopep8 is moving relative imports to top in `digital_device_twins/init.py which results in circular imports.

Specify a priority (low, medium, high)
high

To Reproduce
Steps to reproduce the behavior:

  1. Setup python
  2. Setup virtual environment
  3. Install SIMPA from most recent develop branch
  4. Run pre-commit hook to trigger autopep8 formatting, pre-commit install and bash .git/hooks/pre-commit
  5. Run SIMPA script, for example simpa_examples/minimal_optical_example.py
  6. See circular import error

Current Behavior
Results in circular import error

Expected behavior
Runs example without errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacking week
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant