Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled autopep8 formatting of relative import lines #331

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

TomTomRixRix
Copy link
Collaborator

@TomTomRixRix TomTomRixRix commented Jun 28, 2024

Please check the following before creating the pull request (PR):

  • Did you run automatic tests?
  • Did you run manual tests?
  • Is the code provided in the PR still backwards compatible to previous SIMPA versions?

List any special testing requirements
Please test this once on a different setup which might have another environment

Additional context (e.g. papers, documentation, blog posts, ...)
It is important to have these relative imports after the definition of the DigitalDeviceTwinBase class to avoid circular imports triggered by imported child classes. However, autopep8 moves all imports to the top which is avoided by disabling the formatting in these lines.

Provide issue / feature request fixed by this PR

Fixes #329

Copy link
Collaborator

@kdreher kdreher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kdreher kdreher merged commit 0b96c0c into develop Jun 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants