Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise valueerror if interpolated wavelengths are out of range and wri… #310

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

jnoelke
Copy link
Collaborator

@jnoelke jnoelke commented Jun 26, 2024

…te write documentation more generic

  • add error handling if the wavelength for the get_value_for_wavelength function is smaller or larger than the provided min/max wavelengths
  • There were some specific references to absorption. However, the class is more general and also handles scattering and anisotropy. We therefore wrote the documentation more generic.

Please check the following before creating the pull request (PR):

  • Did you run automatic tests?
  • Did you run manual tests?
  • Is the code provided in the PR still backwards compatible to previous SIMPA versions?

Provide issue / feature request fixed by this PR

Fixes #221

…te write documentation more generic

Co-authored-by: Jonas Burian <jonas.burian@protonmail.com>
@jnoelke jnoelke self-assigned this Jun 26, 2024
Copy link
Collaborator

@kdreher kdreher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants