Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added function for general tissue definition from optical parameters … #326

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

RecurvedBow
Copy link
Collaborator

@RecurvedBow RecurvedBow commented Jun 27, 2024

Please check the following before creating the pull request (PR):

  • Did you run automatic tests?
  • Did you run manual tests?
  • Is the code provided in the PR still backwards compatible to previous SIMPA versions?

Additional context (e.g. papers, documentation, blog posts, ...)
Since TISSUE_LIBRARY.constant() has been changed (it should still have the same behavior), manual tests which use this function should be run. The following are successful:
ReproduceDISMeasurements.py
CompareMCXResultsWithDiffusionTheory.py
AbsorptionAndScatteringWithinHomogenousMedium.py
AbsorptionAndScatteringWithInifinitesimalSlabExperiment.py
ComputeDiffuseReflectance.py

The following manual tests could not be run due to not having Matlab:
KWaveAcousticForwardConvenienceFunction.py

No other manual tests are required.

Provide issue / feature request fixed by this PR

Fixes #283

Copy link
Collaborator

@kdreher kdreher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kdreher kdreher merged commit 21f7d9c into develop Jun 27, 2024
12 checks passed
@RecurvedBow RecurvedBow deleted the T283_GenericTissue branch June 28, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants