-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrapper object that initialises and contains enricher and analyzer objects #34
Add wrapper object that initialises and contains enricher and analyzer objects #34
Conversation
Getting
But having problems installing locally
Also - feel like the |
Hard to details of PR. Seems to work apart from the import issue. Happy to merge if this is fixed. All other issues now in tickets which can be addressed in their own PRs. Will note which ones I think should be fixed for a release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy for you to merge once imports fixed.
I've added a script to install dependencies. It sets couple of env variables to resolve the graphics issue. Should I merge this as it is or should I wait for you to confirm whether the script resolves your issue or not. |
As long as you are confident you can make a build for release with this, I'm happy to merge. It will probably still take some playing around for me to switch to doing poetry builds from Command Line. Currently using PyCharm built-in. |
…ontains-enricher-and-analyzer-objects
dabcbb5
to
8dc5255
Compare
Resolves #32
I have some uncertainty about the wrapper class; it might not align exactly with what you had in mind. Everything seems like working in the workflow you described. It would require some improvement though.
This is what I use in my tries;