Add method to query cl slims #8
Conversation
pandasaurus_cxg/utils/exceptions.py
Outdated
| def __init__(self, invalid_slim_list: List[str], valid_slim_list: list[dict[str, str]]): | ||
| self.message = ( | ||
| f"The following slim names are invalid: " | ||
| f"{', '.join([slim for slim in invalid_slim_list])}. " |
There was a problem hiding this comment.
Can't we directly do ', '.join(invalid_slim_list)
| @@ -15,15 +17,19 @@ def __init__( | |||
| file_path: str, | |||
| cell_type_field: Optional[str] = "cell_type_ontology_term_id", | |||
| context_field: Optional[str] = "tissue_ontology_term_id", | |||
| ontology_list_for_slims: Optional[List[str]] = ["Cell Ontology"], | |||
There was a problem hiding this comment.
We should validate if all ontology titles are valid and raise an exception otherwise.
There was a problem hiding this comment.
Will having a Enum for ontology titles help users to find the correct ontology names?
from enum import Enum
class OntologyNames(Enum):
CL = "Cell Ontology"
ENVO = "The Environment Ontology"
DPO= "Drosophila Phenotype Ontology (DPO)"
....Then users can provide the list as [OntologyNames.CL.value, OntologyNames.ENVO.value]. If ubergraph is extended, users can still use the string values.
There was a problem hiding this comment.
In this particular case, I think we only care about CL but want to leave an option to over-ride.
Validation should be in pandasaurus itself. Pandasaurus also needs more support for letting users know what is possible. We could have a method that lists all ontologies (referencing that in docstring of method for listing slims.)
It looks like your method takes dc:title of ontology. Easy to retrieve a list of these (although be careful about consistency dc namespace).
There was a problem hiding this comment.
It looks like your method takes dc:title of ontology. Easy to retrieve a list of these (although be careful about consistency dc namespace).
This is the query I'm using to retrieve slim details; https://api.triplydb.com/s/lFTW8trIj.
There was a problem hiding this comment.
I have created INCATools/PandaSaurus#21 to keep track
pandasaurus_cxg/anndata_enricher.py
Outdated
| @@ -102,3 +115,19 @@ def set_enricher_property_list(self, property_list: List[str]): | |||
| property_list (List[str]): The list of properties to include in the enrichment analysis. | |||
| """ | |||
| self.__enricher = Query(self.__seed_list, property_list) | |||
|
|
|||
| def is_invalid_slim_list(self, slim_list): | |||
There was a problem hiding this comment.
The name is_invalid_slim_list makes me expect this function to return a boolean value. Should we rename it to validate_slim_list ?
I've added
slim_listattribute to keep track of slim lists. It is initialised with a list of ontology names, the default value is["Cell Ontology"]. I've also added added a custom exception class for invalid slim names.minimal_slim_enrichmentandfull_slim_enrichmentraises that exception in case they are called with invalid slim names.I've added missing anndata dependency.