Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow StimulusExperiment to use any type of intracellular electrode #100

Open
wants to merge 1 commit into
base: v0
Choose a base branch
from

Conversation

apdavison
Copy link
Member

i.e. either sharp or patch

{
"path": "prov:used",
"description": "The cell recorded from",
"class": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to use nsg:Cell as a type of the used entity.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that is specific enough. It is important that the object used in the experiment be a cell-that-has-been-recorded-from.

I had in mind to define "nsg:RecordedCell" as a parent of "nsg:PatchedCell" and "nsg:IntraCellularSharpElectrodeRecordedCell", but I didn't do that yet because I wanted to keep the changes minimal so as to get them deployed as soon as possible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification. I'm all for using nsg:RecordedCell then. I think it makes sense.

],
"@type": "nxv:Schema",
"imports": [
"{{base}}/schemas/neurosciencegraph/commons/activity/v0.1.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to neurosciencegraph/commons/activity/v0.1.4

@MFSY MFSY changed the base branch from master to v0 February 5, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants