-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gutenberg support #1554
Add Gutenberg support #1554
Conversation
…wide in single-column posts
…support needed for > 768px
…inc/test-enqueue.php; use env variable to set whether to run Gutenberg tests in .travis.yml, reduce redundant variables in .travis.yml
…_type' to enqueue Gutenberg assets.
With this in the tests/bootstrap.php: $plugins = get_option( 'active_plugins' );
$plugins[] = 'gutenberg/gutenberg.php';
$ret = update_option( 'active_plugins', $plugins );
error_log(var_export( $ret, true));
error_log(var_export( $plugins, true)); And this in the logs:
Still getting this error:
So I'm going to comment out the pre-5.0 |
…ow that we're using that Largo-wide
In that case, Pinky, we must output an empty string!
Okay, calling it a merge. We can revisit some of these styles more later, in response to peoples' feedback. I suspect we're going to be asked to make the buttons bigger, and do something about pull quote formatting. Child themes will need to enqueue their own editor stylesheets if they want fancy fonts there as well. Gutenberg editor styles are added thusly in Largo in the // Gutenberg support for editor styles; @link https://github.com/WordPress/gutenberg/pull/9008
add_theme_support( 'editor-styles' );
add_editor_style('/css/gutenberg' . $suffix . '.css'); |
Changes:
series landing pagesterm metaAdds WordPress 5.0 to TravisAdd WordPress 5.0 to travis list, remove 4.5 from PHP 5.6 and 4.8 from PHP 7.1 #1557 did thisnon-gutenberg:
Testing:
Why
Because WordPress 5.0 is imminent, and we should prepare for immanentizing the eschaton.
Addresses: