Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portions of Largo_Byline reference $this->author, which has not yet been defined #1547

Closed
benlk opened this issue Oct 9, 2018 · 1 comment
Closed

Portions of Largo_Byline reference $this->author, which has not yet been defined #1547

benlk opened this issue Oct 9, 2018 · 1 comment
Labels
type: bug
Milestone
0.6 - Gutenberg, ...

Comments

@benlk
Copy link
Collaborator

benlk commented Oct 9, 2018

Problem: https://github.com/INN/largo/blob/72cc8433a1be1de4f22789e1ec89496d54a653d9/inc/byline_class.php#L105-L106

Solution: make sure that $this->author is defined as the author object.
@benlk benlk added the type: bug label Oct 9, 2018
@benlk benlk added this to the 0.6 - Performance & SEO milestone Oct 9, 2018
@benlk
Copy link
Collaborator Author

benlk commented Oct 9, 2018

And check that $this->author_id is defined as well; I'm not sure that it actually is when we're calling get_the_author_meta.

@benlk benlk mentioned this issue Oct 9, 2018
Open
benlk added a commit that referenced this issue Nov 8, 2018
@benlk
An undefined variable in the byline class, for #1547
deefc30
@benlk benlk mentioned this issue Nov 8, 2018
Merged
14 tasks
@benlk benlk closed this as completed Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
0.6 - Gutenberg, SEO, Performance
Development

No branches or pull requests
1 participant
@benlk