Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Migrate TestSniperPrinter to JUnit5 #3921

Merged

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented May 12, 2021

#3919

This is the first PR to start the migration to JUnit5. It's a pure refactoring.

I intend to use some JUnit5 features in this test class in the coming weeks, which is why I wanted to start the migration with this particular class :)

@slarse slarse changed the title wip: refactor: Migrate TestSnipePriter to JUnit5 review: refactor: Migrate TestSnipePriter to JUnit5 May 12, 2021
@slarse slarse changed the title review: refactor: Migrate TestSnipePriter to JUnit5 review: refactor: Migrate TestSniperPrinter to JUnit5 May 12, 2021
@monperrus
Copy link
Collaborator

LGTM, will merge.

@monperrus monperrus changed the title review: refactor: Migrate TestSniperPrinter to JUnit5 test: Migrate TestSniperPrinter to JUnit5 May 14, 2021
@monperrus monperrus merged commit c7ea5f3 into INRIA:master May 14, 2021
@monperrus
Copy link
Collaborator

Thanks @slarse

@slarse slarse deleted the issue/3919-migrate-TestSniperPrinter-to-junit5 branch May 14, 2021 14:00
@monperrus monperrus mentioned this pull request Aug 19, 2021
woutersmeenk pushed a commit to woutersmeenk/spoon that referenced this pull request Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants