Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: refactor(*): Convert StringTests to junit5 #4387

Merged

Conversation

MartinWitt
Copy link
Collaborator

@MartinWitt MartinWitt commented Dec 27, 2021

#3919

The following has changed in the code:
In type spoon.test.strings.StringLiteralTest:

  • Replaced junit 4 test annotation with junit 5 test annotation in testSnippetFullClass

In type spoon.test.strings.StringTest:

  • Replaced junit 4 test annotation with junit 5 test annotation in testModelBuildingInitializer

@MartinWitt MartinWitt changed the title wip: refactor(*): Convert test package to junit5 review: refactor(*): Convert test package to junit5 Dec 27, 2021
@SirYwell
Copy link
Collaborator

I think the assertions should be updated to JUnit 5 too

@slarse
Copy link
Collaborator

slarse commented Dec 28, 2021

I think the assertions should be updated to JUnit 5 too

Indeed, see #3919

Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also replace assertions with JUnit5 equivalents

 The following has changed in the code:
Replaced junit 4 test annotation with junit 5 test annotation in testModelBuildingInitializer
Transformed junit4 assert to junt 5 assertion in testModelBuildingInitializer
@MartinWitt MartinWitt force-pushed the refactor/automaticQodana/junit5stringsTest branch from ad265c7 to 073bd76 Compare December 30, 2021 19:09
@MartinWitt MartinWitt changed the title review: refactor(*): Convert test package to junit5 review: refactor(*): Convert StringTests to junit5 Dec 30, 2021
@slarse slarse merged commit a449b2c into INRIA:master Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants