Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate ImportBuilderTest to JUnit 5 #4562

Merged

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

The following has changed in the code:

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in testWithNoImport
  • Replaced junit 4 test annotation with junit 5 test annotation in testWithSimpleImport
  • Replaced junit 4 test annotation with junit 5 test annotation in testWithSimpleImportNoAutoimport
  • Replaced junit 4 test annotation with junit 5 test annotation in testInternalImportWhenNoClasspath
  • Replaced junit 4 test annotation with junit 5 test annotation in testSimpleStaticImport
  • Replaced junit 4 test annotation with junit 5 test annotation in testWithStaticStarredImportFromInterface
  • Replaced junit 4 test annotation with junit 5 test annotation in testWithStaticInheritedImport
  • Replaced junit 4 test annotation with junit 5 test annotation in testWithImportFromItf

JUnit4Assertion

  • Transformed junit4 assert to junit 5 assertion in testWithNoImport
  • Transformed junit4 assert to junit 5 assertion in testWithSimpleImport
  • Transformed junit4 assert to junit 5 assertion in testWithSimpleImportNoAutoimport
  • Transformed junit4 assert to junit 5 assertion in testInternalImportWhenNoClasspath
  • Transformed junit4 assert to junit 5 assertion in testSimpleStaticImport
  • Transformed junit4 assert to junit 5 assertion in testWithStaticStarredImportFromInterface
  • Transformed junit4 assert to junit 5 assertion in testWithStaticInheritedImport
  • Transformed junit4 assert to junit 5 assertion in testWithImportFromItf

 The following has changed in the code:
Replaced junit 4 test annotation with junit 5 test annotation in testWithNoImport
Replaced junit 4 test annotation with junit 5 test annotation in testWithSimpleImport
Replaced junit 4 test annotation with junit 5 test annotation in testWithSimpleImportNoAutoimport
Replaced junit 4 test annotation with junit 5 test annotation in testInternalImportWhenNoClasspath
Replaced junit 4 test annotation with junit 5 test annotation in testSimpleStaticImport
Replaced junit 4 test annotation with junit 5 test annotation in testWithStaticStarredImportFromInterface
Replaced junit 4 test annotation with junit 5 test annotation in testWithStaticInheritedImport
Replaced junit 4 test annotation with junit 5 test annotation in testWithImportFromItf
Transformed junit4 assert to junit 5 assertion in testWithNoImport
Transformed junit4 assert to junit 5 assertion in testWithSimpleImport
Transformed junit4 assert to junit 5 assertion in testWithSimpleImportNoAutoimport
Transformed junit4 assert to junit 5 assertion in testInternalImportWhenNoClasspath
Transformed junit4 assert to junit 5 assertion in testSimpleStaticImport
Transformed junit4 assert to junit 5 assertion in testWithStaticStarredImportFromInterface
Transformed junit4 assert to junit 5 assertion in testWithStaticInheritedImport
Transformed junit4 assert to junit 5 assertion in testWithImportFromItf
@monperrus monperrus merged commit d057355 into INRIA:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants