Include some filters for `position` task #516

gcormier · 2023-11-12T19:35:05Z

gcormier
Nov 12, 2023

KiKit now has components when panelizing. The result is that KiBot will output these in the position job.

I don't see a filter option on position. Is there currently a way to tell KiBot to exclude all components matching *KiKit* when making the pick and place?

Answered by set-soft

Nov 16, 2023

Hi @gcormier !

I think that @yaqwsx is right about exclude_from_pos_files, is something that some people could want to include. Perhaps for special cases and in a separated file, not for pick and place.

Anyways, I managed to make KiBot include components from the PCB in the list of components to be processed by filters. You get a warning in this case, but not for KiKit_ components because we know they are panel stuff.

So now you can apply a filter like this:

kibot:
  version: 1

global:
  field_lcsc_part: LCSC

filters:
  - name: remove_extra
    comment: 'Remove KiKit auxiliary'
    type: generic
    exclude_any:
      - column: References
        regex: "^KiKit_"

outputs:
  - name: 'po…

View full answer

set-soft · 2023-11-13T10:59:59Z

set-soft
Nov 13, 2023
Maintainer

Hi @gcormier !

Did you try using a dnf_filter? (in the options for the position output)

You can use a general filter and remove the components you want.

17 replies

gcormier Nov 15, 2023
Author

Would it be possible to have an parameter in KiKit to determine if exclude_from_pos_files is set or not?

The root of this issue is that for JLC, they do not want fiducials/tooling in the POS. The changes proposed above to KiKit would not fix this issue.

yaqwsx Nov 15, 2023

As I expressed above, deciding if tooling and fiducials should be included should be the decision of the POS export, not building the panel.

set-soft Nov 16, 2023
Maintainer

At the moment, none of the attributes are set as the panel is inherently uncoupled from schematics. At the moment, there is no clear way of making an appropriate schematic for the panel (and there are no plans for dealing with that until there is schematic API).

The mentioned attributes are from the PCB. You can set them using FOOTPRINT::SetAttributes. The values are:

# KiCad 6 module attributes from class_module.h
MOD_THROUGH_HOLE = 1
MOD_SMD = 2
MOD_EXCLUDE_FROM_POS_FILES = 4
MOD_EXCLUDE_FROM_BOM = 8
MOD_BOARD_ONLY = 16  # Footprint has no corresponding symbol
MOD_JUST_ADDED = 32  # The footprint was added by the netlist update
MOD_ALLOW_SOLDERMASK_BRIDGES = 64
MOD_ALLOW_MISSING_COURTYARD = 128

set-soft Nov 16, 2023
Maintainer

Hi @gcormier !

I think that @yaqwsx is right about exclude_from_pos_files, is something that some people could want to include. Perhaps for special cases and in a separated file, not for pick and place.

Anyways, I managed to make KiBot include components from the PCB in the list of components to be processed by filters. You get a warning in this case, but not for KiKit_ components because we know they are panel stuff.

So now you can apply a filter like this:

kibot:
  version: 1

global:
  field_lcsc_part: LCSC

filters:
  - name: remove_extra
    comment: 'Remove KiKit auxiliary'
    type: generic
    exclude_any:
      - column: References
        regex: "^KiKit_"

outputs:
  - name: 'position'
    type: position
    dir: positiondir
    options:
      dnf_filter: remove_extra
      format: CSV
      separate_files_for_front_and_back: false
      only_smd: false

But if you want to create a file with reference positions you can use:

kibot:
  version: 1

global:
  field_lcsc_part: LCSC

filters:
  - name: remove_extra
    comment: 'Remove KiKit auxiliary'
    type: generic
    invert: true
    exclude_any:
      - column: References
        regex: "^KiKit_FID"
      - column: References
        regex: "^KiKit_TO"

outputs:
  - name: 'position'
    type: position
    dir: positiondir
    options:
      dnf_filter: remove_extra
      format: CSV   # CSV or ASCII format
      units: millimeters  # millimeters or inches
      separate_files_for_front_and_back: false
      only_smd: false

Which generates:

Ref,Val,Package,PosX,PosY,Rot,Side
"KiKit_FID_B_1","Fiducial","Fiducial",15.0000,88.5483,0.0000,bottom
"KiKit_FID_B_2","Fiducial","Fiducial",77.3965,88.5483,0.0000,bottom
"KiKit_FID_B_3","Fiducial","Fiducial",15.0000,3.8500,0.0000,bottom
"KiKit_FID_B_4","Fiducial","Fiducial",77.3965,3.8500,0.0000,bottom
"KiKit_FID_T_1","Fiducial","Fiducial",15.0000,88.5483,0.0000,top
"KiKit_FID_T_2","Fiducial","Fiducial",77.3965,88.5483,0.0000,top
"KiKit_FID_T_3","Fiducial","Fiducial",15.0000,3.8500,0.0000,top
"KiKit_FID_T_4","Fiducial","Fiducial",77.3965,3.8500,0.0000,top
"KiKit_TO_1","NPTH","NPTH",5.0000,89.8983,0.0000,top
"KiKit_TO_2","NPTH","NPTH",87.3965,89.8983,0.0000,top
"KiKit_TO_3","NPTH","NPTH",5.0000,2.5000,0.0000,top
"KiKit_TO_4","NPTH","NPTH",87.3965,2.5000,0.0000,top

The JLCPCB template now has an internal filter to remove the KiKit_ references, but you can change the filter from outside if needed.

Will be available in dev when I finish adapting the test cases.

Answer selected by gcormier

gcormier Nov 16, 2023
Author

Thanks!

I was not able to get it to work.

https://github.com/gcormier/kitritiled/blob/b9e15c2d6c8bf6f1f83652a63be6ebae60b3b8cb/pcb/kibot.yaml

Is it because I'm using variant as well in the position job?

set-soft Nov 17, 2023
Maintainer

Hi @gcormier !
Are you sure you are using the dev branch?
I applied your kibot.yaml file to the kitriled example and got: result.zip

gcormier Nov 17, 2023
Author

Sorry, I misunderstood and thought the filters would work with the current production release of KiBot, and the internal JLC template would be updated in dev.

Just tried it with dev and indeed it's working with the filters. :)

Any thoughts on when you'll release the next version? If it's a ways out I can switch my Github actions pipelines to dev.

set-soft Nov 21, 2023
Maintainer

I suggest just switching to dev, I can't promise a release date.

You can switch back when 1.6.4 (or 1.7.0) is released.

yaqwsx · 2023-11-24T19:08:56Z

yaqwsx
Nov 24, 2023

Hi! Before I made any changes, I consulted them with several of my long-term users. I reached to the following conclusion:

Tooling holes should have "board-only"
Mousebites should have "board-only" and "exclude from pos file"

These changes were made in yaqwsx/KiKit@8a54976

6 replies

set-soft Nov 27, 2023
Maintainer

Hi @gcormier !
The above patches aren't mandatory. Current dev code and template will remove KiKit panelization stuff from the position files by default. You can control which ones are removed using custom filters. The docs has some information about how to apply filters to the JLCPCB template.

gcormier Nov 28, 2023
Author

Ok I ran the latest dev. It removed all but tooling holes, those were still present in the POS file

"KiKit_TO_1","NPTH","NPTH",5.0000,-2.5000,0.0000,top
"KiKit_TO_2","NPTH","NPTH",171.0000,-2.5000,0.0000,top
"KiKit_TO_3","NPTH","NPTH",5.0000,-111.4566,0.0000,top
"KiKit_TO_4","NPTH","NPTH",171.0000,-111.4566,0.0000,top

I can filter, but you mentioned it should remove panelization stuff by default (my preferred behaviour as well), so perhaps something needs to be touched up in kibot?

(This was the run https://github.com/gcormier/megadesk_companion/actions/runs/7012340156 . I've look at your code though and it excludes KiKit_* so I'm scratching my head, that should work. I do have only_smd=false set)

set-soft Nov 28, 2023
Maintainer

I think you are not using the internal template, you are using your own implementation of the template. So you must define a filter to exclude the KiKit stuff. Like the _remove_extra filter found in the template.

I suggest using the template, is quite configurable, if it can be adapted to what you need I might add more configuration variables.

gcormier Nov 30, 2023
Author

Ok, I think it's working! :)

Is there a way to override the output folder for the jlcpcb template? EDIT: Found them! https://github.com/INTI-CMNB/KiBot/blob/master/kibot/resources/config_templates/JLCPCB.kibot.yaml

set-soft Nov 30, 2023
Maintainer

And remember you can always RTFM ;-) https://kibot.readthedocs.io/en/latest/configuration/imports.html#internal-templates-parameters

Also note that now you can search in the docs, try with JLCPCB and you'll see, it works very nice. Also check the index entries: https://kibot.readthedocs.io/en/latest/genindex.html

I added a lot, they could help in some cases

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include some filters for `position` task #516

{{title}}

Replies: 2 comments 23 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

Select a reply

Include some filters for position task #516

gcormier Nov 12, 2023

Replies: 2 comments · 23 replies

set-soft Nov 13, 2023 Maintainer

gcormier Nov 15, 2023 Author

yaqwsx Nov 15, 2023

set-soft Nov 16, 2023 Maintainer

set-soft Nov 16, 2023 Maintainer

gcormier Nov 16, 2023 Author

set-soft Nov 17, 2023 Maintainer

gcormier Nov 17, 2023 Author

set-soft Nov 21, 2023 Maintainer

yaqwsx Nov 24, 2023

set-soft Nov 27, 2023 Maintainer

gcormier Nov 28, 2023 Author

set-soft Nov 28, 2023 Maintainer

gcormier Nov 30, 2023 Author

set-soft Nov 30, 2023 Maintainer

Include some filters for `position` task #516

gcormier
Nov 12, 2023

Replies: 2 comments 23 replies

set-soft
Nov 13, 2023
Maintainer

gcormier Nov 15, 2023
Author

set-soft Nov 16, 2023
Maintainer

set-soft Nov 16, 2023
Maintainer

gcormier Nov 16, 2023
Author

set-soft Nov 17, 2023
Maintainer

gcormier Nov 17, 2023
Author

set-soft Nov 21, 2023
Maintainer

yaqwsx
Nov 24, 2023

set-soft Nov 27, 2023
Maintainer

gcormier Nov 28, 2023
Author

set-soft Nov 28, 2023
Maintainer

gcormier Nov 30, 2023
Author

set-soft Nov 30, 2023
Maintainer