56 - Add use cases to get the current authenticated user and log out #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 24, 2023
GPortas
changed the title
|
I have refreshed the branch with the latest develop changes. Thanks! @pdurbin |
pdurbin
reviewed
Apr 26, 2023
There was a problem hiding this comment.
Overall this looks fine. I'm interested in testing this but ideally all three pull requests would be near final before we do so. The one for Dataverse proper is still being discussed.
I did npm run test and everything passed including tests like "logout".
VS Code is complaining about a line in a test. Not a big deal but it would be nice to not see red:
| authRepositoryStub.logout = sandbox.stub().throwsException(testWriteError); | ||
| const sut = new Logout(authRepositoryStub); | ||
|
|
||
| let actualError: WriteError = undefined; |
There was a problem hiding this comment.
VS Code is complaining about this line:
pdurbin
previously approved these changes
May 8, 2023
|
Please note that until we address this issue... ... I am taking on faith that the js-dataverse code (this repo) is the same as the tarball that has been put into the frontend PR. For more discussion: |
kcondon
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the following use cases to the package:
Both operations work given an auth cookie that comes from the JSF UI. It is the only auth mechanism added for the moment to support the SPA MVP. There is a TODO comment, in the ApiRepository file, providing more information and next steps on this.
Which issue(s) this PR closes:
Special notes for your reviewer:
This PR is part of an end-to-end flow that covers three PRs from three different repositories:
Suggestions on how to test this:
Test the end-to-end flow following the frontend repository PR instructions:
Is there a release notes update needed for this change?:
N/A
Additional documentation:
N/A