Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

172 - Integration add FileCriteria to the getFilesCountInfo use case #196

Conversation

MellyGray
Copy link
Contributor

What this PR does / why we need it:

This PR adds the FileCriteria to the getFilesCountInfo use case, so the files count takes into account the filters and search applied to get the files.

Which issue(s) this PR closes:

Special notes for your reviewer:

The e2e tests for the getFilesTotalDownloadSizeByDatasetPersistentId won't work because these PR need to be merged IQSS/dataverse#9960

Suggestions on how to test this:

Step 1: Run the development environment

  1. Run npm I
  2. cd packages/design-system && npm run build
  3. cd ../../
  4. Check that you have a .env file such as the .env.example, with the VITE_DATAVERSE_BACKEND_URL=http://localhost:8000 variable
  5. cd dev-env
  6. ./run-env.sh 9907-file-counts-with-criteria
  7. To check the environment go to http://localhost:8000 and check your local dataverse installation

Step 2: Test Dataset View mode with the implemented changes for the getFilesCountInfo

  1. Go to http://localhost:8000
  2. Login as admin using username: dataverseAdmin and password: admin1
  3. Create a new Dataset
  4. Upload some files with different types, or tags, or access.
  5. From the dataset view mode copy the search parameters from the url. Ex.: ?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
  6. Go to http://localhost:8000/spa/datasets and paste the search parameters. Ex.: http://localhost:8000/spa/datasets?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
  7. You are seeing now the same Dataset in the SPA, check that when you apply some filter to the Files Table, the filters dropdown options are updated with the new available filters after narrowing the search.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

No

Additional documentation:

@MellyGray MellyGray added the Size: 3 A percentage of a sprint. 2.1 hours. label Oct 10, 2023
@MellyGray MellyGray marked this pull request as ready for review October 10, 2023 16:00
@coveralls
Copy link

coveralls commented Oct 10, 2023

Coverage Status

coverage: 98.383% (+0.005%) from 98.378% when pulling ff11177 on feature/172-integration-add-filecriteria-to-the-getfilescountinfo-use-case into c5d6cd8 on develop.

@GPortas GPortas self-assigned this Oct 26, 2023
Base automatically changed from feature/170-integration-files-download-size to develop October 26, 2023 23:07
@GPortas
Copy link
Contributor

GPortas commented Oct 27, 2023

Same building error here! Can you check other PRs? @MellyGray

errbuild

@MellyGray MellyGray assigned GPortas and unassigned MellyGray Oct 27, 2023
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the already known e2e error, we have a component test error:

https://github.com/IQSS/dataverse-frontend/actions/runs/6668791789/job/18125143989?pr=196

The functionality works as expected. We can see how the file type counts are updated here after selecting public access. The .yml file is restricted.

countsgif

@GPortas GPortas assigned MellyGray and unassigned GPortas Oct 30, 2023
@MellyGray MellyGray assigned GPortas and unassigned MellyGray Oct 31, 2023
@MellyGray
Copy link
Contributor Author

@GPortas I fixed the unit tests and there is an opened issue to fix the e2e

@GPortas GPortas assigned GPortas and unassigned GPortas Oct 31, 2023
@GPortas
Copy link
Contributor

GPortas commented Nov 2, 2023

We have a build error in develop when deploying to beta testing:

https://github.com/IQSS/dataverse-frontend/actions/runs/6731104689/job/18295128987

It seems related to storybook. If it's not too big, can we make the fix in this PR to stabilize develop? @MellyGray

…into feature/172-integration-add-filecriteria-to-the-getfilescountinfo-use-case
@MellyGray
Copy link
Contributor Author

@GPortas I fixed the Storybook error, I think that should fix beta

@MellyGray MellyGray removed their assignment Nov 2, 2023
@GPortas GPortas merged commit 668f39e into develop Nov 2, 2023
5 of 6 checks passed
@GPortas GPortas deleted the feature/172-integration-add-filecriteria-to-the-getfilescountinfo-use-case branch November 2, 2023 12:36
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
…ecriteria-to-the-getfilescountinfo-use-case

172 - Integration add FileCriteria to the getFilesCountInfo use case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spike - Integration/Front] Add FileCriteria to the getFilesCountInfo use case
3 participants