-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
172 - Integration add FileCriteria to the getFilesCountInfo use case #196
172 - Integration add FileCriteria to the getFilesCountInfo use case #196
Conversation
Same building error here! Can you check other PRs? @MellyGray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the already known e2e error, we have a component test error:
https://github.com/IQSS/dataverse-frontend/actions/runs/6668791789/job/18125143989?pr=196
The functionality works as expected. We can see how the file type counts are updated here after selecting public access. The .yml file is restricted.
@GPortas I fixed the unit tests and there is an opened issue to fix the e2e |
We have a build error in develop when deploying to beta testing: https://github.com/IQSS/dataverse-frontend/actions/runs/6731104689/job/18295128987 It seems related to storybook. If it's not too big, can we make the fix in this PR to stabilize develop? @MellyGray |
…into feature/172-integration-add-filecriteria-to-the-getfilescountinfo-use-case
@GPortas I fixed the Storybook error, I think that should fix beta |
…ecriteria-to-the-getfilescountinfo-use-case 172 - Integration add FileCriteria to the getFilesCountInfo use case
What this PR does / why we need it:
This PR adds the FileCriteria to the getFilesCountInfo use case, so the files count takes into account the filters and search applied to get the files.
Which issue(s) this PR closes:
Special notes for your reviewer:
The e2e tests for the getFilesTotalDownloadSizeByDatasetPersistentId won't work because these PR need to be merged IQSS/dataverse#9960
Suggestions on how to test this:
Step 1: Run the development environment
npm I
cd packages/design-system && npm run build
cd ../../
.env
file such as the .env.example, with theVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
variablecd dev-env
./run-env.sh 9907-file-counts-with-criteria
Step 2: Test Dataset View mode with the implemented changes for the getFilesCountInfo
?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation: