33 - Create the navigation elements of the design system #54
Conversation
| defaultActiveKey: string | ||
| } | ||
|
|
||
| function Tabs({ defaultActiveKey, children }: PropsWithChildren<TabsProps>) { |
There was a problem hiding this comment.
Shouldn't this have a heading of "Props"? This is what I see:
There was a problem hiding this comment.
@MellyGray yes, you're right. I hope you don't mind but I did git rebase develop on this PR and then force pushed it. The Props heading is there now:
pdurbin
force-pushed
the
feature/create-the-navigation-elements-of-the-design-system
branch
from
4b03d80 to
7ce257a
Compare
|
I'm not sure what I should be seeing, verifying. I see a navbar item in the left hand links column. I open the docs for it and see model navbar header components: links, drop down list, but I do not see tabs? |
When you open storybook there should be 3 elements for the navigation: the Navbar, the Tabs and the Breadcrumbs
|
|
@MellyGray Thanks! I think it was the same -b issue. I wasn't seeing the latest? Anyway, I see them now. |
|
@MellyGray There is a merge conflict with the pr. Can you take a look? |
|
@kcondon I fixed the conflicts now |
kcondon
deleted the
feature/create-the-navigation-elements-of-the-design-system
branch
…ements-of-the-design-system 33 - Create the navigation elements of the design system
What this PR does / why we need it:
This PR adds the navigation elements of the design system. This is the Navbar.tsx, Breadcrumb.tsx and Tabs.tsx components.
Which issue(s) this PR closes:
Special notes for your reviewer:
I added the 3 navigation elements as described in the Design System Analysis following Bootstrap 5 styles. For the Navbar element since it was already developed I just did a refactor to improve readability.
Suggestions on how to test this:
npm run storybook
You can check in the Storybook the Breadcrumbs, Tabs and Navigation elements
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
None
Is there a release notes update needed for this change?:
Added navigation elements of the design system
Additional documentation:
Design System Analysis doc