Skip to content

Commit

Permalink
no-op code cleanup, correct case of publicObject_b #10554
Browse files Browse the repository at this point in the history
  • Loading branch information
pdurbin committed May 30, 2024
1 parent 15ace69 commit ae6cf4e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1063,7 +1063,7 @@ private String getPermissionFilterQuery(DataverseRequest dataverseRequest, SolrQ
StringBuilder sbgroups = new StringBuilder();

// All users, guests and authenticated, should see all the
// documents marked as PublicObject_b:true, at least:
// documents marked as publicObject_b:true, at least:
sb.append(SearchFields.PUBLIC_OBJECT + ":" + true);

// One or more groups *may* also be available for this user. Once again,
Expand Down Expand Up @@ -1161,7 +1161,7 @@ private String getPermissionFilterQuery(DataverseRequest dataverseRequest, SolrQ
* @todo rename this from publicPlusUserPrivateGroup. Confusing
*/
// safe default: public only
String publicPlusUserPrivateGroup = publicOnly;
String publicPlusUserPrivateGroup = publicOnly;
// + (onlyDatatRelatedToMe ? "" : (publicOnly + " OR "))
// + "{!join from=" + SearchFields.GROUPS + " to=" + SearchFields.PERMS + "}id:" + IndexServiceBean.getGroupPerUserPrefix() + au.getId() + ")";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public enum FeatureFlags {
/**
* For published (public) objects, don't use a join when searching Solr.
* Experimental! Requires a reindex with the following feature flag enabled,
* in order to add the boolean PublicObject_b:true field to all the public
* in order to add the boolean publicObject_b:true field to all the public
* Solr documents.
*
* @apiNote Raise flag by setting
Expand All @@ -48,7 +48,7 @@ public enum FeatureFlags {
*/
AVOID_EXPENSIVE_SOLR_JOIN("avoid-expensive-solr-join"),
/**
* With this flag enabled, the boolean field PublicObject_b:true will be
* With this flag enabled, the boolean field publicObject_b:true will be
* added to all the indexed Solr documents for publicly-available collections,
* datasets and files. This flag makes it possible to rely on it in searches,
* instead of the very expensive join (the feature flag above).
Expand Down

0 comments on commit ae6cf4e

Please sign in to comment.