Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journal Custom Metadata Block #1166

Closed
posixeleni opened this issue Nov 25, 2014 · 11 comments
Closed

Journal Custom Metadata Block #1166

posixeleni opened this issue Nov 25, 2014 · 11 comments
Assignees
Labels

Comments

@posixeleni
Copy link
Contributor

Creating a custom Journal Metadata Block to be able to browse datasets by journal volume, issue number and Article Type based on JATS specification. This will be particularly important for journal dataverses that used the collection functionality in 3.6 to achieve this.

@posixeleni posixeleni self-assigned this Nov 25, 2014
@posixeleni posixeleni added this to the Beta 9 - Dataverse 4.0 milestone Nov 25, 2014
posixeleni pushed a commit that referenced this issue Nov 26, 2014
@posixeleni posixeleni assigned pdurbin and unassigned posixeleni Nov 26, 2014
@posixeleni
Copy link
Contributor Author

@pdurbin I added this new metadata block based on @mheppler and @mcrosas feedback to manage collections migration for journals from 3.6 to 4.0. Would you please confirm that this does not need a schema.xml change and then assign to QA?

@pdurbin
Copy link
Member

pdurbin commented Dec 1, 2014

Would you please confirm that this does not need a schema.xml change

A new metadata block like this does require a schema.xml change.

(This can be easily confirmed with vagrant up and attempting to enable and use the new metadata block.)

I went ahead and committed a Solr schema.xml update in 828862d but @posixeleni can you please review it? I'm concerned that the word "volume" can have multiple meanings. I know you mean a volume of a journal but many scientists will think of liters or milliliters.

@eaquigley
Copy link
Contributor

@posixeleni this update is available to review at dataverse-demo since we pushed beta 9. if you don't mind reviewing it and making sure it is the way it should be, that would be great.

@posixeleni
Copy link
Contributor Author

@pdurbin I am not worried about confusing users with the word "volume" since this is in the Journal Metadata Block and the tooltip explains what we mean by Volume. I think there is enough context there so that users are not confused. This metadata block would most likely only be used for Journal Dataverses. Would be great if this block was automatically selected when one picked the Dataverse category for "journal".

@eaquigley I reviewed what is in dvn-build and this looks good to go! We'll get more feedback from journals to improve this block hopefully. Is it ok to close this or send to QA?

@pdurbin
Copy link
Member

pdurbin commented Dec 1, 2014

I am not worried about confusing users with the word "volume"

@posixeleni let's reflect on why we changed "type" to "astroType":

"For field name disambiguation I changed the field names: Change the field name "type" (like astroType) to something less generic (it's fine for displayName to remain as "Type) because these names are used to power Advanced Search as field:searchTerm." -- ticket #85

@sbarbosadataverse
Copy link

Why don't we seek feedback from one of the journal admins? William Jacoby
film ajps is great at responding Eleni.
On Dec 1, 2014 6:24 PM, "Philip Durbin" notifications@github.com wrote:

I am not worried about confusing users with the word "volume"

@posixeleni https://github.com/posixeleni let's reflect on why we
changed "type" to "astroType":

"For field name disambiguation I changed the field names: Change the field
name "type" (like astroType) to something less generic (it's fine for
displayName to remain as "Type) because these names are used to power
Advanced Search as field:searchTerm." -- ticket #85
#85


Reply to this email directly or view it on GitHub
#1166 (comment).

@posixeleni
Copy link
Contributor Author

Sorry @pdurbin I misunderstood your initial feedback since you didn't specify that you were referring to the dataset field name that's in the db and shows up in search box, rather than the dataset field title which shows up more in UI.

I can modify the dataset field name for it to be journalVolume in the tsv for beta 10 since I'm putting in a bunch of changes to metadata blocks then anyways.

@pdurbin
Copy link
Member

pdurbin commented Dec 2, 2014

I can modify the dataset field name for it to be journalVolume in the tsv

Sounds good to me. Would you also use journalIssue rather than issue?

It's probably way to late for this but it would be kind of nice to be able to use the same dataset field name in more than one metadata block. Then on the search side maybe I could just concatenate the fields like "citation.title" or "socialscience.geographicCoverage" or something... I dunno, we should also think about how we are going to translate these into different languages in #326 ("title" vs "título").

@posixeleni
Copy link
Contributor Author

@pdurbin for consistency's sake I will make all the field names in the journal metadata block start with: journal

@scolapasta scolapasta modified the milestones: Beta 12 - Dataverse 4.0, Dataverse 4.0: Final Jan 23, 2015
@posixeleni
Copy link
Contributor Author

@kcondon if you did not test this new block in #1305 then please do so. Should match what is in this tsv https://docs.google.com/spreadsheet/ccc?key=0AjeLxEN77UZodHFEWGpoa19ia3pldEFyVFR0aFVGa0E#gid=8

@kcondon
Copy link
Contributor

kcondon commented Feb 4, 2015

Tested as part of #1305, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants