Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jetty header http size (mydata branch) #2311

Closed
raprasad opened this issue Jul 2, 2015 · 16 comments
Closed

update jetty header http size (mydata branch) #2311

raprasad opened this issue Jul 2, 2015 · 16 comments

Comments

@raprasad
Copy link
Contributor

raprasad commented Jul 2, 2015

part of #2302


@raprasad raprasad added Type: Feature a feature request Status: Dev labels Jul 2, 2015
@scolapasta scolapasta modified the milestone: 4.0.2 Jul 6, 2015
@scolapasta
Copy link
Contributor

@pdurbin should we check in a jetty.xml file into our repository for this? @kcondon

@pdurbin
Copy link
Member

pdurbin commented Jul 24, 2015

Related: #1928

@pdurbin
Copy link
Member

pdurbin commented Jul 24, 2015

@kcondon @raprasad what header size did you decide on?

@pdurbin pdurbin assigned raprasad and unassigned pdurbin Jul 24, 2015
@pdurbin
Copy link
Member

pdurbin commented Jul 28, 2015

Today @scolapasta @raprasad and I discovered that an internal server had the value set to one million. This is quite a bit higher than the "8192" value documented at http://guides.dataverse.org/en/4.1/installation/installation-main.html#solr-configuration

@scolapasta scolapasta modified the milestones: 4.1, 4.2 Jul 31, 2015
@raprasad raprasad closed this as completed Aug 3, 2015
@pdurbin
Copy link
Member

pdurbin commented Aug 3, 2015

@raprasad can you please add some documentation on what the value should be?

@pdurbin pdurbin reopened this Aug 3, 2015
@raprasad
Copy link
Contributor Author

I think it's "102400"

            <Set name="requestHeaderSize">102400</Set>

This should be sanity checked--e.g., a significantly lower number may work fine.

  • e.g. test actual query for dataverseAdmin and go up as needed
            <Set name="requestHeaderSize">61440</Set>

@pdurbin
Copy link
Member

pdurbin commented Jan 26, 2016

This was never documented. I'm stealing this from @raprasad and folding it into #2884.

@kcondon
Copy link
Contributor

kcondon commented Feb 2, 2016

Doc'd closing.

@kcondon kcondon closed this as completed Feb 2, 2016
@pdurbin
Copy link
Member

pdurbin commented Feb 3, 2016

Shoot. @kcondon I need to reopen this issue. @sekmiller just ran into #1439 and in helping him troubleshoot his seemingly empty installation and "Search Syntax Error: Expected content type application/octet-stream but got ." in the Glassfish server.log, I'm realizing that during my rewrite I failed to mention that you have to add the line in question. For now I'll reopen this. Please send it to me when you're ready for me to push a fix to the branch we're using for pull request #2895.

@pdurbin
Copy link
Member

pdurbin commented Feb 23, 2016

@kcondon I noticed you sent this issue back to me yesterday and that the milestone is still 4.3. #2895 has already been merged so please advise if you want a new pull request for just this issue (already listed at #2944 by the way) or if you just want me to fix it quick in "develop" or something.

@kcondon
Copy link
Contributor

kcondon commented Feb 24, 2016

@pdurbin
I think you said the developer should just tell me where to test it, right? What is the process in this case?

@pdurbin
Copy link
Member

pdurbin commented Feb 24, 2016

I brought this up to @scolapasta today during the standup so I'll pass this to him for a decision.

@scolapasta again, please note that this issue is linked from the longer todo list at #2944.

@pdurbin pdurbin assigned scolapasta and unassigned pdurbin Feb 24, 2016
@pdurbin
Copy link
Member

pdurbin commented Feb 25, 2016

@scolapasta I just chatted with @kcondon about this and reviewed what's already at http://guides.dataverse.org/en/4.2.4/installation/config.html#jetty-xml

Because that page already links to https://support.lucidworks.com/hc/en-us/articles/201424796-Error-when-submitting-large-query-strings which explains that you have to add something, I think most people installing Dataverse will figure it out. I recommend moving this out of the 4.3 milestone and dealing with it in #2944 where it's already referenced.

@scolapasta scolapasta removed this from the 4.3 milestone Feb 26, 2016
@scolapasta scolapasta removed their assignment Feb 26, 2016
@pdurbin
Copy link
Member

pdurbin commented Mar 16, 2016

@kcondon heads up that I added a fix to @landreev 's pull request at #3017. You can see what I wrote at 49217a0 or http://guides.dataverse.org/en/4.3-installer-improvements/installation/config.html#jetty-xml

@pdurbin pdurbin added this to the 4.3 milestone Mar 16, 2016
@pdurbin pdurbin removed this from the 4.3 milestone Mar 16, 2016
@kcondon
Copy link
Contributor

kcondon commented Apr 21, 2016

Looks good, closing.

@kcondon kcondon closed this as completed Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants