Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My Data: Perms acquired via Explicit groups do not show role tags. #2487

Closed
kcondon opened this issue Sep 1, 2015 · 5 comments
Closed

My Data: Perms acquired via Explicit groups do not show role tags. #2487

kcondon opened this issue Sep 1, 2015 · 5 comments
Assignees
@kcondon
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Milestone
4.2

Comments

@kcondon
Copy link
Contributor

kcondon commented Sep 1, 2015

This is a regression: it was working in v4.1.

Assign a user to an explicit group, assign that explicit group admin perms to a dataverse that has datasets, go to my data for that user, see the objects in the list but with no roles.
@kcondon kcondon added UX & UI: Design This issue needs input on the design of the UI and from the product owner Priority: Medium Type: Bug a defect labels Sep 1, 2015
@kcondon kcondon added this to the 4.2 milestone Sep 1, 2015
raprasad added a commit that referenced this issue Sep 1, 2015
@raprasad
fix for #2487. (Only for explicit groups)
aa23a33
@raprasad
Copy link
Contributor

raprasad commented Sep 1, 2015

@kcondon, I just checked in a fix for this.

@raprasad raprasad assigned raprasad and kcondon and unassigned raprasad Sep 1, 2015
@kcondon
Copy link
Contributor Author

kcondon commented Sep 1, 2015

@raprasad Mostly working, when display files, role from ds is removed, hide files, reappears.

@kcondon kcondon assigned raprasad and unassigned kcondon Sep 1, 2015
raprasad added a commit that referenced this issue Sep 1, 2015
@raprasad
Fixes for #2487 #2489
ae4f5fe
@raprasad raprasad assigned kcondon and unassigned raprasad Sep 1, 2015
@kcondon kcondon assigned raprasad and unassigned kcondon Sep 1, 2015
@kcondon
Copy link
Contributor Author

kcondon commented Sep 1, 2015

@raprasad The dropped ds roles in the presence of files is still happening, both for groups and individuals. Note: this does not happen when perms are assigned at the ds level.

raprasad added a commit that referenced this issue Sep 2, 2015
@raprasad
Should be fix for #2487. Main issue was comparing 'datasets' to 'Data…
44815a3 
…set'--see issue #2490
@raprasad
Copy link
Contributor

raprasad commented Sep 2, 2015

Found a definite bug which is now fixed. Was able to reproduce bug and fix locally

@raprasad raprasad assigned kcondon and unassigned raprasad Sep 2, 2015
@kcondon
Copy link
Contributor Author

kcondon commented Sep 2, 2015

OK, works now. Closing.

@kcondon kcondon closed this as completed Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
2 participants
@raprasad @kcondon