Multi Select Request Access: Grant list box has unordered file list, unlike file view on dataset page.

[kcondon]

Grant list box has unordered file list, unlike file view on dataset page.

Makes it more difficult to compare to dataset if the ordering is different. Same with file order on view granted file list, unordered.

[mheppler]

The table order is determined by the attribute rowKey="#{roleAssignment.id}".

[mheppler]

Fixed sort order of the file table on the Grant FIle Access and File Access popups on the File Permissions pg. Also added icons to action buttons to better distinguish Grant from Reject.

This code was pushed to the "2572-permissions-ux" branch.

[mheppler]

Sorry, taking this back. Don't seem to have this solved on all three dataTables on the File Permissions pg. The dataTable (Line 236) in the "Grant Access to Users/Groups" popup is still looking random by rowKey="#{file.id}" and not sorted by sortBy="#{file.displayName}".

[mheppler]

The "Grant File Access" popup seems to be the only place that the sortBy attribute is working for. (See attached.)

Sort order needs to be fixed in the following file or users/groups dataTables across the various permissions workflows.

Dataverse/Dataset Permissions

• Users/Groups panel > Users/Groups dataTable

File Permissions

• Users/Groups panel > Requests dataTable
• Users/Groups panel > Grant File Access popup > File Name dataTable
• Users/Groups panel > Users/Groups dataTable
• Users/Groups panel > File Access popup > File Name dataTable
• Users/Groups panel > Grant File Access popup > File Name dataTable
• Restricted Files panel > Restricted Files dataTable
• Restricted Files panel > File Access popup > User/Group Name dataTable
• Restricted Files panel > Grant File Access popup > File Name dataTable

[djbrooke]

The fix for #2657 is in this branch.

[mheppler]

Updated my comment above to make the checklist items clearer as to which dataTable was broken and in which popup from which page.