Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Downloader notifications #2654

Closed
pdurbin opened this issue Oct 19, 2015 · 6 comments
Closed

File Downloader notifications #2654

pdurbin opened this issue Oct 19, 2015 · 6 comments
Assignees
Labels
Type: Bug a defect
Milestone

Comments

@pdurbin
Copy link
Member

pdurbin commented Oct 19, 2015

When the File Downloader role/permission is assigned at the dataset level, a notification is sent with a link to a dataset that the user is unable to view ("Not Authorized") is sent:

notify

We'd like some sort of fix for 4.2.1. See also discussion at #2645 where this bug was originally reported.

@eaquigley
Copy link
Contributor

Workflows for when the file downloader role notification should be sent to an end user:

  • Published Dataset: Assign Role->Notification happens immediately
  • Unpublished Dataset: Assign Role->Publish Dataset->Notification sent to user then (Currently notification is being sent as soon as it is assigned for an unpublished dataset).

@sekmiller
Copy link
Contributor

This issue is handled correctly when you are assigning the downloader role on a given file. It is not currently being handled when the file downloader permission is granted at the dataset level.

@sekmiller
Copy link
Contributor

I have coded the notifications so that they will not be sent on an unpublished dataset and dataverse.

Currently there is a generic notification that applies to all role assignments.

You have been granted the File Downloader role for Child of AKK Dataverse.

@eaquigley if you want there to additional verbiage associated with the granting of specific roles additional logic will have to be added. At this point I'm not sure how much work this will be.

@eaquigley
Copy link
Contributor

@sekmiller I'd like to add in at the end, "You now have access to all restricted and unrestricted files in this dataverse.

Thanks!

@sekmiller
Copy link
Contributor

Disclaimer per Liz added to File downloader notification and emails

@kcondon
Copy link
Contributor

kcondon commented Oct 20, 2015

Notification now only sent when published for file downloader. Extra text added. Closing.

@kcondon kcondon closed this as completed Oct 20, 2015
pdurbin referenced this issue Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect
Projects
None yet
Development

No branches or pull requests

4 participants