-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new APIs in support of rsync #3352
Comments
During the 2016-09-08 SBGrid Sprint Planning meeting ( https://docs.google.com/document/d/1wWSdKUOGA1L7UqFsgF3aOs8_9uyjnVpsPAxk7FObOOI/edit ) this issue was given an effort level of "8". Here are links to the code that was demo'ed the day before:
The biggest unknown for me here is what is meant by the "Upload API". Has it been written already? I'm adding @djbrooke @scolapasta and @bmckinney to help me figure out what the Upload API is. |
@bmckinney @scolapasta @djbrooke and I discussed this and it turns out that what was really meant was Upload Mechanisms API. This is the "setUploadMechanisms" method, for example at https://github.com/bmckinney/dataverse-canonical/blob/069fd8d72bfe96ec93b4005550b0c771dee01fc4/src/main/java/edu/harvard/iq/dataverse/api/Dataverses.java#L775 which is to say that that code has already been written so we should go ahead and make a pull request. I moved this issue to Ready at https://waffle.io/IQSS/dataverse |
@bmckinney and I discussed this issue this morning at https://dataverseteam.slack.com/archives/dcm-merge/p1477917910000400 and I dragged it to "Development" in https://waffle.io/IQSS/dataverse and will assign it to myself since I plan to work on it this week. |
@bmckinney and I discussed this issue today and he said I shouldn't use my old code at https://github.com/pdurbin/dataverse/tree/3145-dcm because he had to tweak it. He's going to leave a comment here about where I should look for the latest code. Thanks! |
I'm picking up work on this again and just pushed some scratch work to pdurbin@172b968 Because pull request #3497 has not yet been merged, I had to steal an update to UserNotification.java and I hard-coded "42" rather than calling |
I learned in a meeting yesterday with @pameyer @djbrooke and @scolapasta yesterday that @bmckinney is apparently working on this. It sounds like the plan is to copy and paste working code from https://github.com/sbgrid/sbgrid-dataverse/tree/feature/dcm-api (unless I'm mistaken) to make a pull request against the main IQSS repo. |
The SBGrid feature overlay was made into a Dataverse branch back on 11/4. I just added a couple bug fixes and merged develop. @pameyer and I have a working DCM at dv.sbgrid.org (basically the demo we showed at the September 2016 meeting). (see: Testing DCM) It includes the UI overlay for DCM (not yet made into a dataverse branch since it hasn't gone through code review, etc.) Finally, see swagger docs for more details. |
sorry, didn't mean to close this! |
@bmckinney ah, good to know that the 3352-dcm-apis branch is in play. Thanks for the reminder. I much prefer working from a branch that's in the main IQSS repo rather than the overlay. |
Moving out of development. This is dependent on #3353 and will be started on when that code is merged. |
I'm closing this issue. We'll create new issues, clarify, and re-estimate if we still need these APIs as part of the new approach for handling large datasets. |
This issue lives on as #3725. |
We'll need to add some new APIs to support adding files using rsync.
The text was updated successfully, but these errors were encountered: