Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new APIs in support of rsync #3352

Closed
djbrooke opened this issue Sep 13, 2016 · 15 comments
Closed

Add new APIs in support of rsync #3352

djbrooke opened this issue Sep 13, 2016 · 15 comments

Comments

@djbrooke
Copy link
Contributor

djbrooke commented Sep 13, 2016

We'll need to add some new APIs to support adding files using rsync.

  • Checksum validation API
  • Upload Mechanisms API (was Upload API)
  • Script Request API
@pdurbin
Copy link
Member

pdurbin commented Sep 13, 2016

During the 2016-09-08 SBGrid Sprint Planning meeting ( https://docs.google.com/document/d/1wWSdKUOGA1L7UqFsgF3aOs8_9uyjnVpsPAxk7FObOOI/edit ) this issue was given an effort level of "8". Here are links to the code that was demo'ed the day before:

The biggest unknown for me here is what is meant by the "Upload API". Has it been written already? I'm adding @djbrooke @scolapasta and @bmckinney to help me figure out what the Upload API is.

@pdurbin
Copy link
Member

pdurbin commented Sep 15, 2016

@bmckinney @scolapasta @djbrooke and I discussed this and it turns out that what was really meant was Upload Mechanisms API. This is the "setUploadMechanisms" method, for example at https://github.com/bmckinney/dataverse-canonical/blob/069fd8d72bfe96ec93b4005550b0c771dee01fc4/src/main/java/edu/harvard/iq/dataverse/api/Dataverses.java#L775 which is to say that that code has already been written so we should go ahead and make a pull request. I moved this issue to Ready at https://waffle.io/IQSS/dataverse

@pdurbin pdurbin added in progress and removed ready labels Sep 20, 2016
@pdurbin pdurbin self-assigned this Sep 20, 2016
@pdurbin pdurbin removed their assignment Sep 26, 2016
@pdurbin pdurbin added the SBGrid label Oct 7, 2016
@pdurbin pdurbin added in progress and removed ready labels Oct 31, 2016
@pdurbin
Copy link
Member

pdurbin commented Oct 31, 2016

@bmckinney and I discussed this issue this morning at https://dataverseteam.slack.com/archives/dcm-merge/p1477917910000400 and I dragged it to "Development" in https://waffle.io/IQSS/dataverse and will assign it to myself since I plan to work on it this week.

@pdurbin pdurbin self-assigned this Oct 31, 2016
@djbrooke djbrooke added ready and removed in progress labels Nov 1, 2016
@pdurbin
Copy link
Member

pdurbin commented Nov 4, 2016

@bmckinney and I discussed this issue today and he said I shouldn't use my old code at https://github.com/pdurbin/dataverse/tree/3145-dcm because he had to tweak it. He's going to leave a comment here about where I should look for the latest code. Thanks!

@djbrooke djbrooke added the ready label Nov 28, 2016
@djbrooke djbrooke added this to the 4.8 - Large Data Upload Integration milestone Dec 20, 2016
@pdurbin pdurbin added in progress and removed ready labels Jan 3, 2017
@pdurbin pdurbin self-assigned this Jan 3, 2017
@djbrooke djbrooke modified the milestones: 4.6.1 - ORCID and File Replace, 4.8 - Large Data Upload Integration Jan 4, 2017
pdurbin added a commit to pdurbin/dataverse that referenced this issue Jan 4, 2017
@pdurbin
Copy link
Member

pdurbin commented Jan 4, 2017

I'm picking up work on this again and just pushed some scratch work to pdurbin@172b968

Because pull request #3497 has not yet been merged, I had to steal an update to UserNotification.java and I hard-coded "42" rather than calling jo.start("FileSystemImportJob", props);. @djbrooke and I agree that the plan is to merge pull request #3497 first. Then I'll merge that code into whatever branch I put through QA for this issue. Next I'm considering making a new branch based on the branch behind pull request #3497 (3353-batch-job-import) so see if that makes more sense, so that I don't have to wait for it to be merged to have a complete solution.

@djbrooke
Copy link
Contributor Author

djbrooke commented Jan 4, 2017

In the planning meeting today, @pdurbin mentioned that he's blocked by the code in #3353 not currently working. @landreev offered his assistance.

A helpful concept (to me, at least) is that someone suggested thinking of this as an API wrapper around the rsync functionality.

@pdurbin
Copy link
Member

pdurbin commented Jan 6, 2017

I learned in a meeting yesterday with @pameyer @djbrooke and @scolapasta yesterday that @bmckinney is apparently working on this. It sounds like the plan is to copy and paste working code from https://github.com/sbgrid/sbgrid-dataverse/tree/feature/dcm-api (unless I'm mistaken) to make a pull request against the main IQSS repo.

@bmckinney
Copy link
Contributor

The SBGrid feature overlay was made into a Dataverse branch back on 11/4. I just added a couple bug fixes and merged develop.

@pameyer and I have a working DCM at dv.sbgrid.org (basically the demo we showed at the September 2016 meeting). (see: Testing DCM) It includes the UI overlay for DCM (not yet made into a dataverse branch since it hasn't gone through code review, etc.)

Finally, see swagger docs for more details.

@bmckinney bmckinney reopened this Jan 6, 2017
@bmckinney
Copy link
Contributor

sorry, didn't mean to close this!

@pdurbin
Copy link
Member

pdurbin commented Jan 6, 2017

@bmckinney ah, good to know that the 3352-dcm-apis branch is in play. Thanks for the reminder. I much prefer working from a branch that's in the main IQSS repo rather than the overlay.

@djbrooke
Copy link
Contributor Author

djbrooke commented Jan 9, 2017

Moving out of development. This is dependent on #3353 and will be started on when that code is merged.

@djbrooke
Copy link
Contributor Author

I'm closing this issue. We'll create new issues, clarify, and re-estimate if we still need these APIs as part of the new approach for handling large datasets.

@pdurbin
Copy link
Member

pdurbin commented Mar 28, 2017

This issue lives on as #3725.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants