Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install script should support non-interactive configuration of options #3799

Closed
pameyer opened this issue Apr 26, 2017 · 11 comments
Closed

install script should support non-interactive configuration of options #3799

pameyer opened this issue Apr 26, 2017 · 11 comments
Assignees
Labels

Comments

@pameyer
Copy link
Contributor

pameyer commented Apr 26, 2017

The existing installation script doesn't support non-interactive configuration of installation options (mail server, postgresql configuration, default contact email address, etc). This causes friction with automated provisioning tools (or requires them to duplicate logic in the installation script).

Options:

  • installation script as a TODO for providing default values in a text file (possibly with hard-coded defaults if that files is missing); this could be implemented
  • command line arguments for these options could be implemented
  • values from environmental variables could be used, with default values being used if they aren't set

Potentially related to #3390

@pameyer
Copy link
Contributor Author

pameyer commented Apr 27, 2017

Bringing previous work on this in sync (mix of option 1 and 2): https://github.com/IQSS/dataverse/tree/3799-noninteractive_installer)

@pameyer pameyer self-assigned this Apr 27, 2017
@pdurbin pdurbin assigned pdurbin and unassigned pameyer Apr 28, 2017
@pdurbin
Copy link
Member

pdurbin commented Apr 28, 2017

@pameyer thanks for the pull request at #3803! I took a quick look and here's what I would suggest:

Thanks!!

@pdurbin
Copy link
Member

pdurbin commented May 2, 2017

I fixed the backticks in 03c0dd0 to be rst style instead of markdown style. This is in pull request #3803

@pameyer you're using -f ... are you piggypacking off --force? Here's GetOptions:

"f|force" => \$force,

@pameyer
Copy link
Contributor Author

pameyer commented May 2, 2017

@pdurbin - thanks for the correction. And it is using the same --force / -f that was already there.

@pdurbin
Copy link
Member

pdurbin commented May 2, 2017

@pameyer ok. Thanks. Moving to QA at https://waffle.io/IQSS/dataverse . The pull request is #3803.

@pdurbin
Copy link
Member

pdurbin commented May 2, 2017

Oh, wait. Not moving to QA yet because I think @landreev wants to take a look. I'm happy with the changes. @kcondon I didn't actually test vagrant up but that would be a good thing to test since it exercises the changes in the pull request.

@pdurbin pdurbin removed their assignment May 2, 2017
@pdurbin
Copy link
Member

pdurbin commented May 2, 2017

@landreev and I just talked about this and we're both happy with the pull request (#3803) so I'm moving this to QA. Again, I'd recommend testing vagrant up.

@pdurbin pdurbin assigned landreev and unassigned landreev May 2, 2017
@kcondon kcondon self-assigned this May 4, 2017
@kcondon
Copy link
Contributor

kcondon commented May 4, 2017

Works but does not seem to set HOST_DNS_ADDRESS and does prompt user to hit enter during process:

Command start-domain executed successfully.
Enter admin user name [Enter to accept default]>

@kcondon kcondon assigned pameyer and unassigned kcondon May 4, 2017
@pameyer
Copy link
Contributor Author

pameyer commented May 4, 2017

Prompting the user does not occur when redirecting stdout and stderr to a file - looks like there are odd interactions between -y and perl system / stty. Will update docs.

@pameyer pameyer removed their assignment May 4, 2017
@kcondon
Copy link
Contributor

kcondon commented May 4, 2017

OK, all works now.

@pameyer
Copy link
Contributor Author

pameyer commented May 5, 2017

Re-checked vagrant after the latest changes; no problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants