As someone playing with demo.dataverse.org, I want to be able to see my notifications without the whole application blowing up #5687

pdurbin · 2019-03-27T15:45:24Z

I mentioned this problem at standup this morning and was told to go ahead and create and issue. At the moment https://demo.dataverse.org is running 3721306 (4.11)

Here's the stacktrace (kudos to @kcondon ):

[2019-03-27T15:39:42.496+0000] [glassfish 4.1] [WARNING] [] [javax.enterprise.resource.webcontainer.jsf.lifecycle] [tid: _ThreadID=169 _ThreadName=jk-connector(27)] [timeMillis: 1553701182496] [levelValue: 900] [[
  #{DataverseUserPage.init}: java.lang.NullPointerException
javax.faces.FacesException: #{DataverseUserPage.init}: java.lang.NullPointerException
        at com.sun.faces.application.ActionListenerImpl.processAction(ActionListenerImpl.java:118)
        at javax.faces.component.UIViewAction.broadcast(UIViewAction.java:562)
        at javax.faces.component.UIViewRoot.broadcastEvents(UIViewRoot.java:790)
        at javax.faces.component.UIViewRoot.processApplication(UIViewRoot.java:1282)
        at com.sun.faces.lifecycle.InvokeApplicationPhase.execute(InvokeApplicationPhase.java:81)
        at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101)
        at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:198)
        at javax.faces.webapp.FacesServlet.service(FacesServlet.java:646)
        at org.apache.catalina.core.StandardWrapper.service(StandardWrapper.java:1682)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:344)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:214)
        at org.glassfish.tyrus.servlet.TyrusServletFilter.doFilter(TyrusServletFilter.java:295)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:256)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:214)
        at org.ocpsoft.rewrite.servlet.RewriteFilter.doFilter(RewriteFilter.java:226)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:256)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:214)
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:316)
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:160)
        at org.apache.catalina.core.StandardPipeline.doInvoke(StandardPipeline.java:734)
        at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:673)
        at com.sun.enterprise.web.WebPipeline.invoke(WebPipeline.java:99)
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:174)
        at org.apache.catalina.core.StandardPipeline.doInvoke(StandardPipeline.java:734)
        at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:673)
        at org.apache.catalina.connector.CoyoteAdapter.doService(CoyoteAdapter.java:412)
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:282)
        at com.sun.enterprise.v3.services.impl.ContainerMapper$HttpHandlerCallable.call(ContainerMapper.java:459)
        at com.sun.enterprise.v3.services.impl.ContainerMapper.service(ContainerMapper.java:167)
        at org.glassfish.grizzly.http.server.HttpHandler.runService(HttpHandler.java:201)
        at org.glassfish.grizzly.http.server.HttpHandler.doHandle(HttpHandler.java:175)
        at org.glassfish.grizzly.http.server.HttpServerFilter.handleRead(HttpServerFilter.java:235)
        at org.glassfish.grizzly.filterchain.ExecutorResolver$9.execute(ExecutorResolver.java:119)
        at org.glassfish.grizzly.filterchain.DefaultFilterChain.executeFilter(DefaultFilterChain.java:284)
        at org.glassfish.grizzly.filterchain.DefaultFilterChain.executeChainPart(DefaultFilterChain.java:201)
        at org.glassfish.grizzly.filterchain.DefaultFilterChain.execute(DefaultFilterChain.java:133)
        at org.glassfish.grizzly.filterchain.DefaultFilterChain.process(DefaultFilterChain.java:112)
        at org.glassfish.grizzly.ProcessorExecutor.execute(ProcessorExecutor.java:77)
        at org.glassfish.grizzly.nio.transport.TCPNIOTransport.fireIOEvent(TCPNIOTransport.java:561)
        at org.glassfish.grizzly.strategies.AbstractIOStrategy.fireIOEvent(AbstractIOStrategy.java:112)
        at org.glassfish.grizzly.strategies.WorkerThreadIOStrategy.run0(WorkerThreadIOStrategy.java:117)
        at org.glassfish.grizzly.strategies.WorkerThreadIOStrategy.access$100(WorkerThreadIOStrategy.java:56)
        at org.glassfish.grizzly.strategies.WorkerThreadIOStrategy$WorkerThreadRunnable.run(WorkerThreadIOStrategy.java:137)
        at org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:565)
        at org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:545)
        at java.lang.Thread.run(Thread.java:745)
Caused by: javax.faces.el.EvaluationException: java.lang.NullPointerException
        at javax.faces.component.MethodBindingMethodExpressionAdapter.invoke(MethodBindingMethodExpressionAdapter.java:101)
        at com.sun.faces.application.ActionListenerImpl.processAction(ActionListenerImpl.java:102)
        ... 45 more
Caused by: java.lang.NullPointerException
        at edu.harvard.iq.dataverse.authorization.providers.builtin.DataverseUserPage.displayNotification(DataverseUserPage.java:475)
        at edu.harvard.iq.dataverse.authorization.providers.builtin.DataverseUserPage.init(DataverseUserPage.java:173)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at com.sun.el.parser.AstValue.invoke(AstValue.java:289)
        at com.sun.el.MethodExpressionImpl.invoke(MethodExpressionImpl.java:304)
        at org.jboss.weld.util.el.ForwardingMethodExpression.invoke(ForwardingMethodExpression.java:40)
        at org.jboss.weld.el.WeldMethodExpression.invoke(WeldMethodExpression.java:50)
        at com.sun.faces.facelets.el.TagMethodExpression.invoke(TagMethodExpression.java:105)
        at javax.faces.component.MethodBindingMethodExpressionAdapter.invoke(MethodBindingMethodExpressionAdapter.java:87)
        ... 46 more
]]

[2019-03-27T15:39:42.496+0000] [glassfish 4.1] [WARNING] [] [javax.enterprise.web] [tid: _ThreadID=169 _ThreadName=jk-connector(27)] [timeMillis: 1553701182496] [levelValue: 900] [[
  StandardWrapperValve[Faces Servlet]: Servlet.service() for servlet Faces Servlet threw exception
java.lang.NullPointerException
        at edu.harvard.iq.dataverse.authorization.providers.builtin.DataverseUserPage.displayNotification(DataverseUserPage.java:475)
        at edu.harvard.iq.dataverse.authorization.providers.builtin.DataverseUserPage.init(DataverseUserPage.java:173)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at com.sun.el.parser.AstValue.invoke(AstValue.java:289)
        at com.sun.el.MethodExpressionImpl.invoke(MethodExpressionImpl.java:304)
        at org.jboss.weld.util.el.ForwardingMethodExpression.invoke(ForwardingMethodExpression.java:40)
        at org.jboss.weld.el.WeldMethodExpression.invoke(WeldMethodExpression.java:50)
        at com.sun.faces.facelets.el.TagMethodExpression.invoke(TagMethodExpression.java:105)
        at javax.faces.component.MethodBindingMethodExpressionAdapter.invoke(MethodBindingMethodExpressionAdapter.java:87)
        at com.sun.faces.application.ActionListenerImpl.processAction(ActionListenerImpl.java:102)
        at javax.faces.component.UIViewAction.broadcast(UIViewAction.java:562)
        at javax.faces.component.UIViewRoot.broadcastEvents(UIViewRoot.java:790)
        at javax.faces.component.UIViewRoot.processApplication(UIViewRoot.java:1282)
        at com.sun.faces.lifecycle.InvokeApplicationPhase.execute(InvokeApplicationPhase.java:81)
        at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101)
        at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:198)
        at javax.faces.webapp.FacesServlet.service(FacesServlet.java:646)
        at org.apache.catalina.core.StandardWrapper.service(StandardWrapper.java:1682)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:344)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:214)
        at org.glassfish.tyrus.servlet.TyrusServletFilter.doFilter(TyrusServletFilter.java:295)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:256)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:214)
        at org.ocpsoft.rewrite.servlet.RewriteFilter.doFilter(RewriteFilter.java:226)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:256)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:214)
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:316)
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:160)
        at org.apache.catalina.core.StandardPipeline.doInvoke(StandardPipeline.java:734)
        at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:673)
        at com.sun.enterprise.web.WebPipeline.invoke(WebPipeline.java:99)
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:174)
        at org.apache.catalina.core.StandardPipeline.doInvoke(StandardPipeline.java:734)
        at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:673)
        at org.apache.catalina.connector.CoyoteAdapter.doService(CoyoteAdapter.java:412)
		        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:282)
        at com.sun.enterprise.v3.services.impl.ContainerMapper$HttpHandlerCallable.call(ContainerMapper.java:459)
        at com.sun.enterprise.v3.services.impl.ContainerMapper.service(ContainerMapper.java:167)
        at org.glassfish.grizzly.http.server.HttpHandler.runService(HttpHandler.java:201)
        at org.glassfish.grizzly.http.server.HttpHandler.doHandle(HttpHandler.java:175)
        at org.glassfish.grizzly.http.server.HttpServerFilter.handleRead(HttpServerFilter.java:235)
        at org.glassfish.grizzly.filterchain.ExecutorResolver$9.execute(ExecutorResolver.java:119)
        at org.glassfish.grizzly.filterchain.DefaultFilterChain.executeFilter(DefaultFilterChain.java:284)
        at org.glassfish.grizzly.filterchain.DefaultFilterChain.executeChainPart(DefaultFilterChain.java:201)
        at org.glassfish.grizzly.filterchain.DefaultFilterChain.execute(DefaultFilterChain.java:133)
        at org.glassfish.grizzly.filterchain.DefaultFilterChain.process(DefaultFilterChain.java:112)
        at org.glassfish.grizzly.ProcessorExecutor.execute(ProcessorExecutor.java:77)
        at org.glassfish.grizzly.nio.transport.TCPNIOTransport.fireIOEvent(TCPNIOTransport.java:561)
        at org.glassfish.grizzly.strategies.AbstractIOStrategy.fireIOEvent(AbstractIOStrategy.java:112)
        at org.glassfish.grizzly.strategies.WorkerThreadIOStrategy.run0(WorkerThreadIOStrategy.java:117)
        at org.glassfish.grizzly.strategies.WorkerThreadIOStrategy.access$100(WorkerThreadIOStrategy.java:56)
        at org.glassfish.grizzly.strategies.WorkerThreadIOStrategy$WorkerThreadRunnable.run(WorkerThreadIOStrategy.java:137)
        at org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:565)
        at org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:545)
        at java.lang.Thread.run(Thread.java:745)
]]

My username on demo is "philip_durbin":

The text was updated successfully, but these errors were encountered:

RightInTwo · 2019-03-28T13:22:04Z

It has been like that for a while... Sorry for not reporting it!

pdurbin · 2019-03-28T13:24:29Z

😞

pdurbin · 2019-03-28T13:27:16Z

Here's the line that's throwing the NullPointerException

https://github.com/IQSS/dataverse/blob/v4.11/src/main/java/edu/harvard/iq/dataverse/authorization/providers/builtin/DataverseUserPage.java#L475

That is to say that file is null in the file.getOwner() line below:

            case REQUESTFILEACCESS:
                DataFile file = fileService.find(userNotification.getObjectId());
                userNotification.setTheObject(file.getOwner());
                break;

mheppler · 2019-06-20T17:06:18Z

Related to:

Notifications: page slow to load and results in time-out when many undeleted notifications Notifications: page slow to load and results in time-out when many undeleted notifications #2892
Notifications: Request access notification appears as object was deleted message. Notifications: Request access notification appears as object was deleted message. #2340
Notifications: In some cases, users receive more than one notification for a single event, eg. request access. Notifications: In some cases, users receive more than one notification for a single event, eg. request access. #4120
Notifications: send only one notification for each "batch" request access Notifications: send only one notification for each "batch" request access #2891
(and ultimately...) Revisit notifications Revisit notifications #1336

Some of these could probably be closed and consolidated into one issue to refactor notifications, if not as a whole, then at the very least for the request access feature, which is will be a more prominent feature with the upcoming DataTags integration.

djbrooke · 2019-06-26T18:21:46Z

possibly related to requesting access to a file that's later deleted (this is the scenario to try and reproduce first)
we did previous work in this area to better handle deleted objects, but maybe we missed something
since it's in demo, it's very likely related to deletions since we destroy things every monthish :)

pdurbin · 2019-07-10T20:54:11Z

I can easily reproduce the 500 error with the following steps:

A user requests access to a file.
A superuser destroys the dataset.
The file/dataset owner attempts to check notifications.

I just created pull request #6008 to fix this. The idea is to show the generic "The dataverse, dataset, or file for this notification has been deleted" error we use elsewhere instead, like in the screenshot below:

The pull request has additional screenshots.

scolapasta · 2019-07-11T23:24:09Z

New info: I don't think that a missing file is the only cause of this. I just debugged an issue in production where and old request from 2016 was causing this to happen. The object_id of that notification leads to a dataset. SO, I think the issue could be because we switched from tracking the dataset here to the file? If so, the dataset object id will not be found by the file Service bean.

I think it's worth at least looking at the change history and verifying if this is the case. If so, then just saying it's been deleted may not be the best solution. Or it may be, since I don't recall at this moment when we made the change.

sekmiller · 2019-07-12T14:19:13Z

The reason that we put the dataset into the notification is so that we can put a link to the manage file permissions page in the notification. That link needs a dataset id.

scolapasta · 2019-07-12T19:13:24Z

After some investigation, it turns out the access request notiication was always tracking a file, that was incorrect on my part.

However there is an issue in that a subset of notifications pre mid 2017 got corrupted and are incorrect. So @sekmiller is adding to the release notes associated with this issue to delete all pre 2018 notifications.

for deleting invalidated notifications

generic REQUESTFILEACCESS notification when dataset destroyed #5687

pdurbin changed the title ~~As someone playing with demo.dataverse.org, I want to be able to see my notifications without the whole application belowing up~~ As someone playing with demo.dataverse.org, I want to be able to see my notifications without the whole application blowing up Mar 27, 2019

pdurbin added Feature: Notifications Help Wanted: Code Mentor: pdurbin labels Mar 28, 2019

djbrooke added ready for estimation labels Apr 3, 2019

djbrooke self-assigned this Apr 3, 2019

djbrooke removed Feature: Notifications Help Wanted: Code Mentor: pdurbin ready for estimation labels Apr 5, 2019

djbrooke removed their assignment Apr 10, 2019

djbrooke added the Small label May 9, 2019

djbrooke removed the Status: Ready label May 22, 2019

mheppler added the Feature: Notifications label Jun 20, 2019

djbrooke self-assigned this Jun 26, 2019

djbrooke removed their assignment Jun 26, 2019

pdurbin self-assigned this Jul 9, 2019

pdurbin added a commit that referenced this issue Jul 10, 2019

generic REQUESTFILEACCESS notification when dataset destroyed #5687

f824697

pdurbin mentioned this issue Jul 10, 2019

generic REQUESTFILEACCESS notification when dataset destroyed #5687 #6008

Merged

pdurbin removed their assignment Jul 11, 2019

pdurbin added a commit that referenced this issue Jul 11, 2019

Merge branch 'develop' into 5687-notifications #5687

618ee54

sekmiller added a commit that referenced this issue Jul 12, 2019

#5687 add release notes

1c6d928

for deleting invalidated notifications

kcondon closed this as completed in #6008 Jul 15, 2019

kcondon added a commit that referenced this issue Jul 15, 2019

Merge pull request #6008 from IQSS/5687-notifications

221e7fb

generic REQUESTFILEACCESS notification when dataset destroyed #5687

pdurbin added this to the 4.16 milestone Oct 12, 2019

pdurbin mentioned this issue Nov 19, 2019

Notifications: page slow to load and results in time-out when many undeleted notifications #2892

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

As someone playing with demo.dataverse.org, I want to be able to see my notifications without the whole application blowing up #5687

As someone playing with demo.dataverse.org, I want to be able to see my notifications without the whole application blowing up #5687

pdurbin commented Mar 27, 2019

RightInTwo commented Mar 28, 2019

pdurbin commented Mar 28, 2019

pdurbin commented Mar 28, 2019

mheppler commented Jun 20, 2019

djbrooke commented Jun 26, 2019

pdurbin commented Jul 10, 2019

scolapasta commented Jul 11, 2019

sekmiller commented Jul 12, 2019

scolapasta commented Jul 12, 2019

As someone playing with demo.dataverse.org, I want to be able to see my notifications without the whole application blowing up #5687

As someone playing with demo.dataverse.org, I want to be able to see my notifications without the whole application blowing up #5687

Comments

pdurbin commented Mar 27, 2019

RightInTwo commented Mar 28, 2019

pdurbin commented Mar 28, 2019

pdurbin commented Mar 28, 2019

mheppler commented Jun 20, 2019

djbrooke commented Jun 26, 2019

pdurbin commented Jul 10, 2019

scolapasta commented Jul 11, 2019

sekmiller commented Jul 12, 2019

scolapasta commented Jul 12, 2019