Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a dataset is moved from one dataverse to another, the dataset should take on the new dataverse workflow #6575

Closed
sbarbosadataverse opened this issue Jan 24, 2020 · 6 comments · Fixed by #10729
Assignees
Labels
Feature: In Review Workflow Feature: Permissions FY25 Sprint 1 FY25 Sprint 1 issues FY25 Sprint 2 FY25 Sprint 2 issues Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect
Milestone

Comments

@sbarbosadataverse
Copy link

a dataset was moved from a journal to harvard root after it had been submitted for review.
in root, the dataset workflow setting did not change from that of the journal-"submit for review" was not removed

see attached screen shot

Screen Shot 2020-01-24 at 12 56 46 PM

*i requested permission from journal to move published dataset back to their journal dataverse as should be the case

@djbrooke djbrooke changed the title Moving feature bug: when a dataset is moved from one dataverse to another, the dataset should take on the new dataverse workflow When a dataset is moved from one dataverse to another, the dataset should take on the new dataverse workflow Jan 25, 2020
@djbrooke
Copy link
Contributor

djbrooke commented Jan 25, 2020

Thanks @sbarbosadataverse for reporting. Before we work on this, we'll need to determine what status is expected when a move occurs under different conditions.

@sbarbosadataverse
Copy link
Author

I deleted the dataset because the author needed to recreate it in the journal dataverse for publishing. just an FYI

@cmbz
Copy link

cmbz commented May 6, 2024

2024/05/06

  • The logic of what aspects of previous workflow state are preserved or cleared after the move will need to be defined. One idea: clear the previous state whenever a dataset is moved to a new location.

@pdurbin
Copy link
Member

pdurbin commented May 8, 2024

We have a SubmitDatasetForReviewCommand. Would a WithdrawDatasetFromReviewCommand be appropriate? That is, put it back in the state it was in before it was submitted for review. I think removing the lock (DatasetLock.Reason.InReview) is the main thing. I'm not sure if we'd want to send notifications or not. "This dataset has been withdrawn from review." 🤔

Anyway, a new command could be useful in cases that don't involve moving datasets.

We should discuss the plan and scope before we size this.

@cmbz cmbz added the Size: 10 A percentage of a sprint. 7 hours. label Jul 10, 2024
@cmbz
Copy link

cmbz commented Jul 10, 2024

Sized at 10, needs a bit more investigation. Resize as needed.

@cmbz cmbz added FY25 Sprint 1 FY25 Sprint 1 issues FY25 Sprint 2 FY25 Sprint 2 issues labels Jul 10, 2024
@sekmiller sekmiller self-assigned this Jul 25, 2024
sekmiller added a commit that referenced this issue Jul 26, 2024
@sekmiller
Copy link
Contributor

The logic added here is based on the permissions granted to the default contributor of the target Dataverse. If a dataset that is locked for review is moved to a collection where the default contributor may publish datasets, then the lock is removed.

sekmiller added a commit that referenced this issue Jul 26, 2024
stevenwinship pushed a commit that referenced this issue Aug 2, 2024
…author can publish (#10729)

* #6575 remove lock if default role in target collection can publish

* #6575 Add unit tests

* #6575 format source
@pdurbin pdurbin added this to the 6.4 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: In Review Workflow Feature: Permissions FY25 Sprint 1 FY25 Sprint 1 issues FY25 Sprint 2 FY25 Sprint 2 issues Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect
Projects
Status: Done
5 participants