Include Postgres JDBC driver in pom.xml

[poikilotherm]

(I looked everywhere, but I could not find an existing issue for this, thus creating a new. This is related to my old epic #5292 and had a commit for it, see df2b8cc)

Modern app servers are capable to load the JDBC driver from the deployed WAR when setting up database connections.

This makes manual installation of the Postgres driver obsolete and enables usage during integration tests with Testcontainers.

The addition to pom.xml is very simple:

<dependency>
    <groupId>org.postgresql</groupId>
    <artifactId>postgresql</artifactId>
    <version>42.2.12</version>
</dependency>

In addition, instead of letting the installer configure the database connection in domain.xml, we can provide the connection details either from annotations (Java EE standard compliant, should be preferred) or provide them from glassfish-resources.xml (which also support variables substitution from domain, environment or alias).

Note: the above has been skipped as beyond scope for now. Small steps.

Obviously, this affects a lot of places. Docs (#6593), installer (#6761), container images, ...
It makes updating and testing much easier: there is only ONE place to change the version, ideally by using a Maven property.

I already tested this a while ago, see links below.
What I don't remember: it's not clear if the timers database can be used for this, too. IIRC this is why I created #5345...

See also:

• payara/docker-payaraserver-full#69
• https://github.com/poikilotherm/dataverse/blob/65a88d14f22679d2405b09a50757e6bc5ebdf08c/pom.xml#L709-L721
• poikilotherm@e1b3f42#diff-d705b5d323debe3ee2bb19639ba12b48

[poikilotherm]

The timers are re-using the applications data source. Even complaining about preexisting tables. 🐌

[#|2020-07-01T18:57:58.086+0000ESC[1;92m|INFO|ESC[0mPayara 5.201|ESC[1;94morg.eclipse.persistence.session./file:/opt/pa
yara/appserver/glassfish/domains/production/applications/ejb-timer-service-app/WEB-INF/classes/___EJB__Timer__App.conne
ction|ESC[0m_ThreadID=1;_ThreadName=main;_TimeMillis=1593629878086;_LevelValue=800;|
/file:/opt/payara/appserver/glassfish/domains/production/applications/ejb-timer-service-app/WEB-INF/classes/___EJB__Timer__App login successful|#]

[#|2020-07-01T18:57:58.092+0000ESC[1;93m|WARNING|ESC[0mPayara 5.201|ESC[1;94mjavax.org.glassfish.persistence.org.glassfish.persistence.common|ESC[0m_ThreadID=1;_ThreadName=main;_TimeMillis=1593629878092;_LevelValue=900;|
PER01000: Got SQLException executing statement "CREATE TABLE "EJB__TIMER__TBL" ("TIMERID" VARCHAR(255) NOT NULL, "APPLICATIONID" BIGINT, "BLOB" BYTEA, "CONTAINERID" BIGINT, "CREATIONTIMERAW" BIGINT, "INITIALEXPIRATIONRAW" BIGINT, "INTERVALDURATION" BIGINT, "LASTEXPIRATIONRAW" BIGINT, "OWNERID" VARCHAR(255), "PKHASHCODE" INTEGER, "SCHEDULE" VARCHAR(255), "STATE" INTEGER, PRIMARY KEY ("TIMERID"))": org.postgresql.util.PSQLException: ERROR: relation "EJB__TIMER__TBL" already exists|#]

[#|2020-07-01T18:57:58.112+0000ESC[1;92m|INFO|ESC[0mPayara 5.201|ESC[1;94mjavax.enterprise.ejb.container|ESC[0m_ThreadID=1;_ThreadName=main;_TimeMillis=1593629878112;_LevelValue=800;_MessageID=AS-EJB-00054;|
Portable JNDI names for EJB TimerBean: [java:global/ejb-timer-service-app/TimerBean, java:global/ejb-timer-service-app/TimerBean!org.glassfish.ejb.persistent.timer.TimerLocal]|#]

[#|2020-07-01T18:57:58.164+0000ESC[1;92m|INFO|ESC[0mPayara 5.201|ESC[1;94mjavax.enterprise.web|ESC[0m_ThreadID=1;_ThreadName=main;_TimeMillis=1593629878164;_LevelValue=800;_MessageID=AS-WEB-GLUE-00172;|
Loading application [ejb-timer-service-app] at [/ejb-timer-service-app]|#]

[#|2020-07-01T18:57:58.578+0000ESC[1;92m|INFO|ESC[0mPayara 5.201|ESC[1;94mjavax.enterprise.system.container.ejb.com.sun.ejb.containers|ESC[0m_ThreadID=1;_ThreadName=main;_TimeMillis=1593629878578;_LevelValue=800;|
EJB5109:EJB Timer Service started successfully for data source [jdbc/VDCNetDS]|#]

[#|2020-07-01T18:57:58.579+0000ESC[1;92m|INFO|ESC[0mPayara 5.201|ESC[1;94mjavax.enterprise.system.container.ejb.com.sun.ejb.containers|ESC[0m_ThreadID=1;_ThreadName=main;_TimeMillis=1593629878579;_LevelValue=800;|
==> Restoring Timers ... |#]

[xoroz]

any news on this ?

[pdurbin]

@xoroz back in July I did a quick test of a pull request by @poikilotherm and left a review here: #7048 (review)

There's additional conversation in that pull request.