Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update schema.xml in-place #7903

Closed
Kris-LIBIS opened this issue May 26, 2021 · 0 comments · Fixed by #8130
Closed

Update schema.xml in-place #7903

Kris-LIBIS opened this issue May 26, 2021 · 0 comments · Fixed by #8130

Comments

@Kris-LIBIS
Copy link
Contributor

With PR #7865 in place, the updateSchemaMDB.sh script no longer works as intended. It used to update the Solr schema by updating two XML files that were included in the schema.xml. Issue #7864 indicated that this update mechanism did not work and after the fix, the schema.xml file should be updated manually.

In order to restore the fully 'automatic' update without breaking #7864, the updateSchemaMDB.sh script should modify the schema.xml directly instead of updating the included XML files.
This was referenced May 26, 2021
Closed
Merged
@pdurbin pdurbin mentioned this issue Aug 24, 2021
Closed
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 4, 2021
@poikilotherm
refactor(solr): remove external field config file IQSS#7903
9dfda2b 
As of IQSS#7865 (merged DV 5.6), the Solr Schema XML file
did not include <copyField>s for metadata schemas from
an external file anymore. Instead they had been included.

This broke the updateSchemaMDB.sh script, which is IQSS#7903

This commit will remove the other include construction for
<field> definitions (plus remove the file) and include the
content directly in the schema.

It also introduced some docs about the whereabouts of these
fields plus (most importantly) INCLUDE GUARDS. These are
going to be used for new scripting of half-automatic index
management.

IQSS#7903
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 4, 2021
@poikilotherm
feat(solr): add new schema config script update-field.sh IQSS#7903
d74e463 
Removing the old updateSchemaMDB.sh script, as it's broken.
It's also of limited use for the container use case it had been
invented for.

Replacing with a script capable of taking the solr schema bits
and stuffing it into a prepared schema.xml file.

IQSS#7903
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 4, 2021
@poikilotherm
docs(metadata): refactor metadata customization with new solr script I…
e92eff4 
…QSS#7903
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 4, 2021
@poikilotherm
refactor(solr): remove references to updateSchemaMDB.sh IQSS#7903
e6a6bf9
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 4, 2021
@poikilotherm
refactor(solr): include new update-fields.sh instead of updateSchemaM…
70f60b1 
…DB.sh in installer IQSS#7903
@poikilotherm poikilotherm mentioned this issue Oct 4, 2021
Merged
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 4, 2021
@poikilotherm
docs(solr): add release note for update-fields.sh IQSS#7903
1288bbd
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 4, 2021
@poikilotherm
ci(solr): start adding shellspec tests for update-fields.sh IQSS#7903
c24f034
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(solr): finish shellspec tests for update-fields.sh IQSS#7903
63f3f80
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
feat(solr): add some more validation and make update-fields.sh less n…
97d1a55 
…oisy IQSS#7903
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci: add shellspec github workflow IQSS#7903
ff829ef
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci: add shellspec github workflow IQSS#7903
638f14e
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci: add shellspec github workflow IQSS#7903
37ea000
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci: add shellspec github workflow IQSS#7903
7cb28a9
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
refactor(solr): readlink not available on MacOS, delete from update-f…
2d7dc63 
…ields.sh IQSS#7903
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(shellspec): make MacOS run on modern Bash IQSS#7903
c5a1761
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(shellspec): make MacOS run on modern Bash IQSS#7903
06a864c
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(shellspec): make MacOS run on modern Bash IQSS#7903
d017dc3
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(shellspec): make MacOS run on modern Bash IQSS#7903
e9cdb50
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
refactor(solr): make update-fields.sh require Bash v4 IQSS#7903
02a0df2
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
refactor(solr): make update-field.sh use [[ tests for integers, tryin…
651b48c 
…g to make MacOS happy IQSS#7903
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
refactor(solr): make update-field.sh use [[ tests for integers, tryin…
d742cc1 
…g to make MacOS happy IQSS#7903
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(solr): do not test on MacOS due to VERY strange bash problems IQSS…
bfb8243 
…#7903
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
refactor(solr): add bash v4+ requirement for update-fields.sh IQSS#7903
84aa193
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(solr): skip update-fields.sh test for no input if on Github IQSS#7903
b9d1672 


Inside update-fields.sh we detect if a STDIN is given as a pipe via
testing if FD 0 (stdin) is not attached to a terminal.
This does not work inside a Github Action, so skip this for now till
we see a problem or find a better solution.
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(solr): skip update-fields.sh test for no input if on Github IQSS#7903
84be4f1 


Inside update-fields.sh we detect if a STDIN is given as a pipe via
testing if FD 0 (stdin) is not attached to a terminal.
This does not work inside a Github Action, so skip this for now till
we see a problem or find a better solution.
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(solr): skip update-fields.sh test for no input if on Github IQSS#7903
d903a6f 


Inside update-fields.sh we detect if a STDIN is given as a pipe via
testing if FD 0 (stdin) is not attached to a terminal.
This does not work inside a Github Action, so skip this for now till
we see a problem or find a better solution.
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(solr): skip update-fields.sh test for no input if on Github IQSS#7903
44ee9eb 


Inside update-fields.sh we detect if a STDIN is given as a pipe via
testing if FD 0 (stdin) is not attached to a terminal.
This does not work inside a Github Action, so skip this for now till
we see a problem or find a better solution.
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(solr): add Shellcheck as Github Action IQSS#7903
9fb2bb8
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(solr): test adding a CentOS based shellspec run IQSS#7903
e8f7636
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(solr): test adding a CentOS based shellspec run IQSS#7903
0fb1b67
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(solr): test adding a CentOS based shellspec run IQSS#7903
baef977
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(solr): test adding a RockyLinux based shellspec run IQSS#7903
3ec0549
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(solr): test adding a RockyLinux based shellspec run IQSS#7903
850fd00
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(solr): test adding a RockyLinux based shellspec run IQSS#7903
1add862
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
feat(solr): let update-fields.sh check for presence of ed and bc IQSS…
3cd8acc 
…#7903
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
feat(solr): let update-fields.sh check for presence of ed and bc IQSS…
310b700 
…#7903
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(solr): test adding a RockyLinux based shellspec run IQSS#7903
05e2df4
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
feat(solr): let update-fields.sh check for presence of ed and bc IQSS…
5ee63a4 
…#7903
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
ci(solr): test adding a RockyLinux based shellspec run IQSS#7903
ea6a1b9
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 5, 2021
@poikilotherm
feat(solr): let update-fields.sh check for presence of ed and bc IQSS…
194a5e0 
…#7903
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 26, 2021
@poikilotherm
ci(solr): re-add MacOS shellspec test for update-fields.sh IQSS#7903
736e70b
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 26, 2021
@poikilotherm
ci(solr): re-add MacOS shellspec test for update-fields.sh IQSS#7903
c5b09ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

7903 solr config hack poikilotherm/dataverse
Fix for #7903 update schema.xml in place
1 participant
@Kris-LIBIS