Duplicate template seems to create db entries even when cancel

[scolapasta]

I noticed this strange db behavior - clone a template, click cancel and then look in db. A new row is still added to template table (but with no dataverse_id). Looking at prod, there are many of these orphaned templates.

We need to fix this logic and clean up the db.

[mreekie]

Prio meeting:
Came up while testing 500 server error when adding a a dataset in dataverse where default template has no associated terms. Leaving this in will add to cruft in the databvase

The def of done:

• Write a script to cleanup/fix older templates.
• May not require a new release to use the script, but will likely be documented as part of the release notes.

[pdurbin]

Huh, from a quick test it looks like two copies are created when you copy/clone:

dvndb=> select id,createtime,name,dataverse_id from template;
 id |       createtime        |       name        | dataverse_id 
----+-------------------------+-------------------+--------------
  1 | 2022-05-10 15:19:35.767 | template1         |            1
  2 | 2022-05-10 15:20:50.841 | Copy of template1 |             
  3 | 2022-05-10 15:20:50.841 | Copy of template1 |             
(3 rows)

[mreekie]

sprint:

• Still small
• Been reproduced.