Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher tag in oai_dc format #8739

Open
tcoupin opened this issue May 25, 2022 · 4 comments · May be fixed by #9013
Open

Publisher tag in oai_dc format #8739

tcoupin opened this issue May 25, 2022 · 4 comments · May be fixed by #9013
Labels
Feature: Harvesting NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... pm.GREI-d-1.4.1 NIH, yr1, aim4, task1: Resolve OAI-PMH harvesting issues Type: Bug a defect User Role: API User Makes use of APIs

Comments

@tcoupin
Copy link
Member

tcoupin commented May 25, 2022

When oai_dc format is used for harvesting, publisher tag is used as producerName: https://github.com/IQSS/dataverse/blob/v5.10.1/src/main/resources/db/migration/afterMigrate__1-7256-upsert-referenceData.sql#L34

But the citation block in the datasets list does not show it because it uses the distributor name field:

OAI-PMH response:

image

Citation:
image

Citation from remote dataverse:
image

solr:
image

What steps does it take to reproduce the issue?

  • When does this issue occur?

  • Which page(s) does it occurs on?

  • What happens?

  • To whom does it occur (all users, curators, superusers)?

  • What did you expect to happen?

Which version of Dataverse are you using?

5.10.1

Any related open or closed issues to this bug report?

Screenshots:

No matter the issue, screenshots are always welcome.

To add a screenshot, please use one of the following formats and/or methods described here:

@tcoupin tcoupin changed the title Publisher tag in oai_dc format WIP Publisher tag in oai_dc format May 25, 2022
@tcoupin tcoupin changed the title WIP Publisher tag in oai_dc format Publisher tag in oai_dc format May 25, 2022
@tcoupin
Copy link
Member Author

tcoupin commented May 30, 2022

Suggestion: update table foreignmetadatafieldmapping to map publisher tag to distributorname

update foreignmetadatafieldmapping set datasetfieldname = 'distributorName' where foreignfieldxpath = ':publisher';

@pdurbin
Copy link
Member

pdurbin commented Oct 1, 2022

@tcoupin to you want to go ahead and make a pull request for this? (Thanks for all the pull requests so far!) It would be a way to get the discussion going, perhaps.

Also, I'm thinking this would be a great example of where we could use some automated testing, to make some assertions of what happens with harvesting if you put a value in this or that field.

@tcoupin
Copy link
Member Author

tcoupin commented Oct 3, 2022

Yes I can do a PR. We already have made this SQL update on dataverse.ird.fr

@tcoupin tcoupin linked a pull request Oct 3, 2022 that will close this issue
@mreekie mreekie added NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... and removed NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... labels Oct 25, 2022
@mreekie mreekie removed the NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... label Nov 2, 2022
pdurbin added a commit to tcoupin/dataverse that referenced this issue Jan 3, 2023
@mreekie mreekie added the NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... label Mar 1, 2023
@mreekie
Copy link

mreekie commented Mar 1, 2023

Grooming:

  • This looks to fix a harvesting issue.
  • Associating the deliverable.

@mreekie mreekie added the pm.GREI-d-1.4.1 NIH, yr1, aim4, task1: Resolve OAI-PMH harvesting issues label Mar 20, 2023
@pdurbin pdurbin added Type: Bug a defect User Role: API User Makes use of APIs labels Oct 9, 2023
pdurbin added a commit to tcoupin/dataverse that referenced this issue May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Harvesting NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... pm.GREI-d-1.4.1 NIH, yr1, aim4, task1: Resolve OAI-PMH harvesting issues Type: Bug a defect User Role: API User Makes use of APIs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants