Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some email notifications have empty "" in subject (bug in #9056) #9172

Closed
qqmyers opened this issue Nov 17, 2022 · 1 comment · Fixed by #9173
Closed

Some email notifications have empty "" in subject (bug in #9056) #9172

qqmyers opened this issue Nov 17, 2022 · 1 comment · Fixed by #9173
Milestone

Comments

@qqmyers
Copy link
Member

qqmyers commented Nov 17, 2022

What steps does it take to reproduce the issue?
#9056 changed several messages to include the dataset diplayname in quotes in the message. However the PR code assumes that the object being sent to the message is the dataset and the displayname is left blank when the object is the datasetversion. (FWIW: The bug was introduced during review in trying to avoid a null pointer for messages that don't use either of these object types.)

  • What happens?
    When messages are sent - they say things like Qualitative Data Repository: Dataset "" Status Change
    Which version of Dataverse are you using?
    5.12.1

PR to follow

@pdurbin pdurbin added this to the 5.13 milestone Dec 15, 2022
@pdurbin pdurbin changed the title Some messages have empty "" (bug in #9056) Some email notifications have empty "" in subject (bug in #9056) Jan 4, 2023
@pdurbin
Copy link
Member

pdurbin commented Jan 4, 2023

I just tweaked the title of this issue because (based on the PR) the fix only seems to affect email notifications.

Thank you @kcondon for helping me find it! And thanks to @qqmyers for the fix, of course.

I was affected by this bug when I re-published my dataset at https://doi.org/10.7910/DVN/TJCLKP and here's a screenshot:

Screen Shot 2023-01-04 at 9 31 10 AM

As of this writing Harvard Dataverse is running 5.12.1. The fix has been merged and will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants