Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QDR/9172-fix messages #9173

Merged

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Nov 17, 2022

What this PR does / why we need it: #9056 added the dataset displayname to some messages but a bug/partial fix introduced in review led to some messages display an empty "". This PR fixes that.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this: Do what's needed to generate messages of any/all types below and verify that the message includes the dataset displayname. If one works, they all should.

CREATEDS:
SUBMITTEDDS:
PUBLISHEDDS:
PUBLISHFAILED_PIDREG:
RETURNEDDS:
WORKFLOW_SUCCESS:
WORKFLOW_FAILURE:
STATUSUPDATED:

Regression testing: The message to users when a dataset is created should also show the dataset display name. No other messages (such as REQUESTFILEACCESS) should be broken.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: no? relatively minor message display bug

Additional documentation:

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0008%) to 19.98% when pulling 7620247 on QualitativeDataRepository:QDR/9172-fix-messages into 803a6e9 on IQSS:develop.

haarli added a commit to MPDL/dataverse that referenced this pull request Nov 23, 2022
@mreekie mreekie added the Size: 3 A percentage of a sprint. 2.1 hours. label Dec 14, 2022
@mreekie
Copy link

mreekie commented Dec 14, 2022

Raised by Gary.
Definitely required for the next release.
When we send email messages, there is a text string identifying the dataset id that is now blank.
Simple PR
Sized at a 3

@mreekie
Copy link

mreekie commented Dec 14, 2022

added to sprint Dec 15, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Some email notifications have empty "" in subject (bug in #9056)
6 participants