Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Series" field needs to be made multiple in the "all fields" sample json in the guide #9633

Closed
landreev opened this issue Jun 5, 2023 · 3 comments · Fixed by #9636
Closed
Assignees
Milestone

Comments

@landreev
Copy link
Contributor

landreev commented Jun 5, 2023

Note: this needs to be done before 5.14!

The field "series" has been made multiple since 5.13. However, the example "all fields" json file we provide in the guide (scripts/api/data/dataset-create-new-all-default-fields.json) still has a single-value entry for it, making the json unimportable, once the soc. sci. metadata block is updated:

            "typeName": "series",
            "multiple": false,
            "typeClass": "compound",
            "value": {
              "seriesName": {
              ...

It just needs to be updated the same way we've already updated the file src/test/java/edu/harvard/iq/dataverse/export/ddi/dataset-create-new-all-ddi-fields.json (used by the ddi export tests):

           "typeName": "series",
            "multiple": true,
            "typeClass": "compound",
            "value": [ 
              {
                ...

Worth noting that we've been through the same issue with the other field that was recently made multiple - productionPlace. Plus there were all sorts of other things that were missed when those 2 fields were updated in their respective blocks that we had to keep fixing. I will open an issue for documenting a checklist of all such things and all the places where things need to be changed. So we can make it 100% the responsibility of the developer, if (God forbid) anyone else ever needs to make another existing single field multiple. (edit: opened #9634)

@cmbz
Copy link

cmbz commented Jun 7, 2023

Added 5.14 milestone to reflect dependency.

poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Jun 12, 2023
@landreev landreev self-assigned this Jun 12, 2023
@cmbz cmbz moved this to SPRINT- NEEDS SIZING in IQSS Dataverse Project Jun 14, 2023
@cmbz
Copy link

cmbz commented Jun 14, 2023

Moved item to Needs Sizing because issue must be resolved for 5.14 release.

@poikilotherm
Copy link
Contributor

poikilotherm commented Jun 14, 2023

Please note @cmbz : there is already a PR and it's sized. IMHO we can just inherit that size.

@github-project-automation github-project-automation bot moved this from SPRINT- NEEDS SIZING to Clear of the Backlog in IQSS Dataverse Project Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants