Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netbeans, integration tests, Docker #9974

Closed
pdurbin opened this issue Oct 4, 2023 · 4 comments · Fixed by #9989
Closed

Netbeans, integration tests, Docker #9974

pdurbin opened this issue Oct 4, 2023 · 4 comments · Fixed by #9989
Labels
Component: Containers Anything related to cloudy Dataverse, shipped in containers. Feature: Developer Guide Size: 0.5 A percentage of a sprint. 0.35 hours
Milestone

Comments

@pdurbin
Copy link
Member

pdurbin commented Oct 4, 2023

Now that we've merged...

.... Netbeans users see Caused by: java.lang.IllegalStateException: Could not find a valid Docker environment. Please see logs and check configuration if they try to build and don't have Docker running.

From the thread in Slack, @poikilotherm suggests reconfiguring Netbeans like this:

image

We should try it out and make a PR to update a future versions of https://guides.dataverse.org/en/6.0/developers/classic-dev-env.html#build-the-dataverse-software-war-file above where we say to click build in Netbeans:

Screenshot 2023-10-04 at 5 14 13 PM

@pdurbin pdurbin added Feature: Developer Guide Component: Containers Anything related to cloudy Dataverse, shipped in containers. Size: 0.5 A percentage of a sprint. 0.35 hours labels Oct 4, 2023
@poikilotherm
Copy link
Contributor

poikilotherm commented Oct 4, 2023

I think I'm in favor of skipping any Testcontainers test when no Docker is available and still keep integration tests active by default, just like you don't skip unit tests by default.

Simply using @Testcontainers(disabledWithoutDocker = true) does the trick.

The output of Maven will still show that the tests have been up for running, but where skipped:
image

@pdurbin
Copy link
Member Author

pdurbin commented Oct 5, 2023

@poikilotherm sounds like a great fix for now.

Longer term, we should figure out where we want the integration tests to run. I don't know if Docker is installed on Jenkins or the EC2 instances it spins up, for example.

@poikilotherm
Copy link
Contributor

FWIW: They already run in Github Actions, just not for the unit tests job, but in the IT job right after 😉

@pdurbin
Copy link
Member Author

pdurbin commented Oct 5, 2023

Right, right. I think we touched on this briefly during the container meeting this morning. That's how Coveralls gets updated, by GitHub Action. So as we add integrations tests, our coverage shown there should go up.

poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 10, 2023
As many of IQSS and external devs might not have Docker available,
let's deactivate any Testcontainers tests in these cases.
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Oct 10, 2023
@pdurbin pdurbin added this to the 6.1 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Containers Anything related to cloudy Dataverse, shipped in containers. Feature: Developer Guide Size: 0.5 A percentage of a sprint. 0.35 hours
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants