-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netbeans, integration tests, Docker #9974
Comments
@poikilotherm sounds like a great fix for now. Longer term, we should figure out where we want the integration tests to run. I don't know if Docker is installed on Jenkins or the EC2 instances it spins up, for example. |
FWIW: They already run in Github Actions, just not for the unit tests job, but in the IT job right after 😉 |
Right, right. I think we touched on this briefly during the container meeting this morning. That's how Coveralls gets updated, by GitHub Action. So as we add integrations tests, our coverage shown there should go up. |
As many of IQSS and external devs might not have Docker available, let's deactivate any Testcontainers tests in these cases.
Now that we've merged...
.... Netbeans users see
Caused by: java.lang.IllegalStateException: Could not find a valid Docker environment. Please see logs and check configuration
if they try to build and don't have Docker running.From the thread in Slack, @poikilotherm suggests reconfiguring Netbeans like this:
We should try it out and make a PR to update a future versions of https://guides.dataverse.org/en/6.0/developers/classic-dev-env.html#build-the-dataverse-software-war-file above where we say to click build in Netbeans:
The text was updated successfully, but these errors were encountered: