#10069 add new suggestion template #10091

DS-INRAE · 2023-11-03T14:35:35Z

What this PR does / why we need it:
Add a new issue template for suggestion to distinguish them from feature request at creation

Which issue(s) this PR closes:

Closes Feature Request/Idea: Dissociate and label issue templates for Features & Ideas #10069

Additional documentation:
Previous similar issue :

Automatically add "Type: Feature" issue label to new feature request issues #10081

Add new ideas

sekmiller · 2024-05-29T19:07:49Z

.github/ISSUE_TEMPLATE/idea_proposal.md

+Start below this comment section.
+-->
+
+**Overview of the Feature Request**


Do we want to call this "Idea Suggestion" , not "Feature Request" here?

sekmiller · 2024-05-29T19:08:17Z

.github/ISSUE_TEMPLATE/idea_proposal.md

+**Overview of the Feature Request**
+
+
+**What kind of user is the feature intended for?**


Again, "suggestion" for "feature"?

sekmiller · 2024-05-29T19:09:06Z

.github/ISSUE_TEMPLATE/idea_proposal.md

+**Any brand new behavior do you want to add to Dataverse?**
+
+
+**Any open or closed issues related to this feature request?**


again, "idea or suggestion"?

sekmiller · 2024-05-29T19:10:56Z

@DS-INRA Dimitri, it looks like there are cut and paste issues with the body of the template. Please take a look. Thanks!

pdurbin

I'm just raising awareness of the upcoming Contributor Guide.

pdurbin · 2024-06-07T19:22:41Z

.github/ISSUE_TEMPLATE/idea_proposal.md

+More information on ideas/feature requests and contributions can be found in the "Contributing to Dataverse" page:
+https://github.com/IQSS/dataverse/blob/develop/CONTRIBUTING.md#ideasfeature-requests


Heads up that in this PR we plan to move content from CONTRIBUTING.md to its own guide:

Add a Contributor Guide #10532

So that #ideasfeature-requests link won't work anymore.

sekmiller · 2024-07-09T20:47:27Z

@DS-INRA Dimitri when you have some time please let me know what you think about my comments/questions above. Thanks!

DS-INRAE · 2024-07-15T08:52:06Z

@DS-INRA Dimitri when you have some time please let me know what you think about my comments/questions above. Thanks!

Hello, sorry for the long delay, I should have more time to get back on this after this week :)

changed "feature (request)" to idea or suggestion

Also updated link to the contributor guide

Update contributor guide link Added section for contribution

DS-INRAE · 2024-07-23T13:23:19Z

Thanks for the reviews!
I changed the "feature" mentions and updated the contributor's guide link (including in existing issue templates)
I also added the section:

**Will you be able to contribute a Pull Request for this issue?**  
Help is always welcome, is this bug something you or your organization plan to fix ?

to the existing issue templates, but can take it back if deemed irrelevant :)

sekmiller

Thanks for the updates, Dimitri. Looks good!

pdurbin

Just some thoughts.

pdurbin · 2024-07-23T21:05:18Z

.github/ISSUE_TEMPLATE/bug_report.md

@@ -53,3 +52,6 @@ To add a screenshot, please use one of the following formats and/or methods desc

 * https://help.github.com/en/articles/file-attachments-on-issues-and-pull-requests
 *
+
+**Will you be able to contribute a Pull Request for this issue?**  


Suggested change

**Will you be able to contribute a Pull Request for this issue?**

**Will you be able to contribute a pull request for this issue?**

changed with the last comment's rephrasing

.github/ISSUE_TEMPLATE/bug_report.md

pdurbin · 2024-07-23T21:06:07Z

.github/ISSUE_TEMPLATE/feature_request.md

+**Will you be able to contribute a Pull Request for this issue?**  
+Help is always welcome, is this bug something you or your organization plan to fix ?


Suggested change

**Will you be able to contribute a Pull Request for this issue?**

Help is always welcome, is this bug something you or your organization plan to fix ?

**Will you be able to contribute a pull request for this issue?**

Help is always welcome, is this bug something you or your organization plan to fix?

changed with the last comment's rephrasing

pdurbin · 2024-07-23T21:06:48Z

.github/ISSUE_TEMPLATE/idea_proposal.md

+**Will you be able to contribute a Pull Request for this issue?**  
+Help is always welcome, is this suggestion something you or your organization plan to implement ?


Suggested change

**Will you be able to contribute a Pull Request for this issue?**

Help is always welcome, is this suggestion something you or your organization plan to implement ?

**Will you be able to contribute a pull request for this issue?**

Help is always welcome, is this suggestion something you or your organization plan to implement?

changed with the last comment's rephrasing

pdurbin · 2024-07-23T21:09:00Z

.github/ISSUE_TEMPLATE/feature_request.md

@@ -11,8 +11,7 @@ assignees: ''
 Thank you for contributing to the Dataverse Project through the creation of a feature request!


Above, should we change

title: 'Feature Request/Idea:'

to just

title: 'Feature Request:'

? That is, remove "idea" now that we have a dedicate template for ideas?

Nice catch! I removed "Idea"

pdurbin · 2024-07-23T21:11:58Z

.github/ISSUE_TEMPLATE/bug_report.md

@@ -53,3 +52,6 @@ To add a screenshot, please use one of the following formats and/or methods desc

 * https://help.github.com/en/articles/file-attachments-on-issues-and-pull-requests
 *
+


At a high level, "Will you be able to contribute a pull request for this issue?" strikes me as somewhat strong.

What if they say "yes" but it doesn't work out? Will they feel bad?

Instead should we say something softer like "Are you thinking about creating a pull request for this issue?"

That way they won't feel as "on the hook", I would hope.

Sure, it does sound less intimidating

Co-authored-by: Philip Durbin <philipdurbin@gmail.com>

removed "Idea" Changed the PR paragraph

DS-INRAE · 2024-07-24T07:27:42Z

@pdurbin I have updated the templates according to all the comments 🙂

add new suggestion template

13dae9d

DS-INRAE marked this pull request as ready for review November 3, 2023 14:36

martinAmouzou added 8 commits February 7, 2024 11:13

Update idea_proposal.md

4008c41

Add new ideas

Update feature_request.md

f1fd8d6

Update bug_report.md

06ea894

Update feature_request.md

6d6933f

Update feature_request.md

c388f2e

Update bug_report.md

4ec450f

Update idea_proposal.md

1cec693

Update PULL_REQUEST_TEMPLATE.md

dc0c219

pdurbin added the Size: 0.5 A percentage of a sprint. 0.35 hours label Feb 28, 2024

sekmiller reviewed May 29, 2024

View reviewed changes

sekmiller self-assigned this May 30, 2024

pdurbin reviewed Jun 7, 2024

View reviewed changes

sekmiller added the Status: Needs Input Applied to issues in need of input from someone currently unavailable label Jun 10, 2024

pdurbin assigned DS-INRAE Jul 10, 2024

DS-INRAE added 7 commits July 23, 2024 15:08

Update idea_proposal.md

2628a91

changed "feature (request)" to idea or suggestion

Added "contributing" section to bug_report.md

95cb9ad

Also updated link to the contributor guide

Merge branch 'IQSS:develop' into 10069-add-suggestion-template

255b81e

update contributor guide link idea_proposal.md

972b327

remove unnecessary '"contributing" in PR template

bfcc278

Update contributor guide link in bug_report.md

dab88d3

Update feature_request.md

da82c75

Update contributor guide link Added section for contribution

sekmiller approved these changes Jul 23, 2024

View reviewed changes

sekmiller unassigned sekmiller and DS-INRAE Jul 23, 2024

pdurbin reviewed Jul 23, 2024

View reviewed changes

DS-INRAE and others added 5 commits July 24, 2024 09:11

remove punctuation spaces bug_report.md

b22a558

Co-authored-by: Philip Durbin <philipdurbin@gmail.com>

Update feature_request.md

376bbfa

removed "Idea" Changed the PR paragraph

Update PR paragraph in bug_report.md

a05c260

Update PR paragraph in idea_proposal.md

454787b

Add a space back

b1a0f17

stevenwinship self-assigned this Jul 24, 2024

stevenwinship merged commit 4abfb24 into IQSS:develop Jul 24, 2024
1 of 2 checks passed

stevenwinship removed their assignment Jul 24, 2024

pdurbin added this to the 6.4 milestone Jul 24, 2024

luddaniel deleted the 10069-add-suggestion-template branch September 19, 2024 14:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#10069 add new suggestion template #10091

#10069 add new suggestion template #10091

DS-INRAE commented Nov 3, 2023

sekmiller May 29, 2024

sekmiller May 29, 2024

sekmiller May 29, 2024

sekmiller commented May 29, 2024

pdurbin left a comment

pdurbin Jun 7, 2024

sekmiller commented Jul 9, 2024

DS-INRAE commented Jul 15, 2024

DS-INRAE commented Jul 23, 2024

sekmiller left a comment

pdurbin left a comment

pdurbin Jul 23, 2024

DS-INRAE Jul 24, 2024

pdurbin Jul 23, 2024

DS-INRAE Jul 24, 2024

pdurbin Jul 23, 2024

DS-INRAE Jul 24, 2024

pdurbin Jul 23, 2024

DS-INRAE Jul 24, 2024

pdurbin Jul 23, 2024

DS-INRAE Jul 24, 2024

DS-INRAE commented Jul 24, 2024

		Overview of the Feature Request


		What kind of user is the feature intended for?

		Any brand new behavior do you want to add to Dataverse?


		Any open or closed issues related to this feature request?

		More information on ideas/feature requests and contributions can be found in the "Contributing to Dataverse" page:
		https://github.com/IQSS/dataverse/blob/develop/CONTRIBUTING.md#ideasfeature-requests

	Will you be able to contribute a Pull Request for this issue?
	Will you be able to contribute a pull request for this issue?

		Will you be able to contribute a Pull Request for this issue?
		Help is always welcome, is this bug something you or your organization plan to fix ?

		Will you be able to contribute a Pull Request for this issue?
		Help is always welcome, is this suggestion something you or your organization plan to implement ?

		@@ -11,8 +11,7 @@ assignees: ''
		Thank you for contributing to the Dataverse Project through the creation of a feature request!

		@@ -53,3 +52,6 @@ To add a screenshot, please use one of the following formats and/or methods desc

		* https://help.github.com/en/articles/file-attachments-on-issues-and-pull-requests
		*

#10069 add new suggestion template #10091

#10069 add new suggestion template #10091

Conversation

DS-INRAE commented Nov 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sekmiller commented May 29, 2024

pdurbin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sekmiller commented Jul 9, 2024

DS-INRAE commented Jul 15, 2024

DS-INRAE commented Jul 23, 2024

sekmiller left a comment

Choose a reason for hiding this comment

pdurbin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DS-INRAE commented Jul 24, 2024