6630 lastlogintime not updated #10135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqmyers
reviewed
Nov 22, 2023
There was a problem hiding this comment.
Looks like a straight-froward fix. The one question I have is whether it would be better to just include
@EJB
UserServiceBean userService;
to be able to call userService.updateLastLogin rather than creating a pass-though method in the AuthenticationServiceBean. Not a major concern but I think just using @ejb would be cleaner unless there's a reason to avoid that.
|
Hello @qqmyers , Yes you are right, the method was initially there to include other calls |
qqmyers
approved these changes
May 6, 2024
There was a problem hiding this comment.
@stevenferey - another one where I think all that's needed is merging with develop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR closes:
Closes #6630
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: