Facets filter labels not translated in result block #10158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I blindly merged this code into a test branch of mine and it seemed to help: #10694 (comment) |
|
Good news if it's help ! I can close my PR if it's include into yours |
|
Sorry, I wasn't clear. Please don't close this PR as we plan to test it separately (but I'm not sure when). Thanks. |
pdurbin
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
The code looks reasonable and Iike I said at #10158 (comment) I did some light testing of this PR in a different context (while looking at #10694 (comment) ). Approved.
@jeromeroucou we released 6.4 today so please merge the latest from "develop" into this PR when you get a chance. Thanks.
|
QA: Tested with Spanish and saw the translated value |
jeromeroucou
deleted the
9408_facets_filter_labels_not_translated_result_block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With this PR we have a translated facets filters on search block result, same as facets labels (on the left panel)
Which issue(s) this PR closes:
Special notes for your reviewer:
I do 3 commits :
staticSolrFieldFriendlyNamesBySolrFieldis now get resource bundle. So we doesn't have to keep the quick fix for Search Results - Publication Status Facet Weirdness #618Suggestions on how to test this:
To test this PR, I would recommend activating internationalization