Make licenses searchable and facetable #10204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…searchable in API and filterable in GUI facets
pdurbin
reviewed
Jan 5, 2024
There was a problem hiding this comment.
I didn't run the code but it looks good and the video is fantastic! I feel vindicated that very little code was required to add this feature! 🎉
I left a few comments. Thanks, @luddaniel! ❤️
doc/release-notes/9060-7482-make-licenses-searchable-faceatable.md
Outdated
Show resolved
Hide resolved
doc/release-notes/9060-7482-make-licenses-searchable-faceatable.md
Outdated
Show resolved
Hide resolved
| @@ -239,7 +239,7 @@ private List<String> getSolrFilterQueries(boolean totalCountsOnly){ | |||
| //fq=publicationStatus:"Unpublished"&fq=publicationStatus:"Draft" | |||
|
|
|||
| // ----------------------------------------------------------------- | |||
| // (4) FQ by dataset metadata vlidity | |||
| // (4) FQ by dataset metadata validity | |||
| @@ -741,23 +744,23 @@ public SolrQueryResponse search( | |||
| // logger.info("field: " + facetField.getName() + " " + facetFieldCount.getName() + " (" + facetFieldCount.getCount() + ")"); | |||
| String localefriendlyName = null; | |||
| if (facetFieldCount.getCount() > 0) { | |||
| if(metadataBlockName.length() > 0 ) { | |||
| localefriendlyName = getLocaleTitle(datasetFieldName,facetFieldCount.getName(), metadataBlockName); | |||
| if(metadataBlockName.length() > 0 ) { | |||
There was a problem hiding this comment.
Here and below it looks like we're fixing some whitespace problems. Only three spaces or something.
|
Just added Custom Terms and internationalization on license facet. Also suggestions of first review by @pdurbin. demo_license_facet_i18n.mp4 |
pdurbin
changed the title
|
FWIW: QDR is running this in production. |
Very cool to see this at https://data.qdr.syr.edu ! 
@philippconzett et al., check it out! |
|
2024/01/29
|
qqmyers
approved these changes
Feb 21, 2024
|
QA: works great. Also edited licenses after publishing and was very happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR allow user to filter by License via GUI Facets and via Search API
fqparameter.Which issue(s) this PR closes:
Special notes for your reviewer:
There is 2 ideas that I decided to discard :
Feel free to give your thoughts.
Suggestions on how to test this:
This has been tested with 2 datasets of different licenses and 1 file.
Ex. of search API queries :
http://localhost:8080/api/search?q=*&fq=license%3A%22CC+BY+4.0%22
{"status":"OK","data":{"q":"*","total_count":2http://localhost:8080/api/search?q=*&fq=license%3A%22CC0+1.0%22
{"status":"OK","data":{"q":"*","total_count":1Does this PR introduce a user interface change?
GUI demo :
demo_license_facet_search_solr.mp4
Is there a release notes update needed for this change?
Yes