For Binder, replace girder_ythub with new static page redirect #10361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
changed the title
landreev
approved these changes
Mar 11, 2024
I just flipped this to main. |
This was referenced Mar 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Binder is effectively down because the redirect service we have been relying on is no longer operational.
Which issue(s) this PR closes:
Special notes for your reviewer:
The doc change points to the main/default branch of https://github.com/IQSS/dataverse-binder-redirect but to preview how the README will look until IQSS/dataverse-binder-redirect#2 is merged, you can go to https://github.com/IQSS/dataverse-binder-redirect/tree/1-redirct
Note that GitHub Pages is currently building off that "1-redirct" branch so that we can test and improve the code before we merge IQSS/dataverse-binder-redirect#2 (we'll switch GitHub Pages to build from the "main" branch after we merge).
The old "girder_ythub" passed siteUrl and apiToken but I don't believe either of these are actually used. Binder doesn't care what the siteUrl is. It just downloads based on DOI. And I don't think Binder knows how to use our API token (I may be wrong about that).
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
None.