Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow optional Croissant exporter to replace JSON-LD <head> content #10382

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Allow optional Croissant exporter to replace JSON-LD <head> content #10382

merged 5 commits into from
Mar 21, 2024

Conversation

jp-tosca
Copy link
Contributor

@jp-tosca jp-tosca commented Mar 15, 2024 •
edited by pdurbin
Loading

What this PR does / why we need it:

When the new Croissant PR is ready it will replace the content on the header for LD-JSON, this PR will make that the dataset page check for croissants, and if not found it will provide the old LD-JSON, this will preserve current functionality and allow simply drop the croissant Jar on the exporters folder.

Which issue(s) this PR closes:

Partially closes # #10341

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@jp-tosca jp-tosca added Feature: Metadata Size: 10 A percentage of a sprint. 7 hours. NIH CAFE Issues related to and/or funded by the NIH CAFE project labels Mar 15, 2024
@jp-tosca jp-tosca self-assigned this Mar 15, 2024
@coveralls
Copy link

coveralls commented Mar 15, 2024 •
edited
Loading

Coverage Status

coverage: 20.568% (-0.01%) from 20.578%
when pulling 7023fbf on le-croissant-exportateur
into 1dd5fa4 on develop.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@jp-tosca jp-tosca changed the title Add dataverse support for croissant exporter Add dataverse support for croissant exporter 🥐 ☕ Mar 16, 2024
@pdurbin pdurbin changed the title Add dataverse support for croissant exporter 🥐 ☕ Add dataverse support for Croissant exporter 🥐 ☕ Mar 16, 2024
@pdurbin pdurbin changed the title Add dataverse support for Croissant exporter 🥐 ☕ Add Dataverse support for Croissant exporter 🥐 ☕ Mar 16, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
pdurbin
pdurbin reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jp-tosca from discussion in tech hours just now, I'd say this PR is close.

Can you please add a release note snippet?

We might want a different title. "Allow optional Croissant exporter to replace JSON-LD <head> content"?

@jp-tosca jp-tosca marked this pull request as ready for review March 19, 2024 20:40
@jp-tosca jp-tosca changed the title Add Dataverse support for Croissant exporter 🥐 ☕ Allow optional Croissant exporter to replace JSON-LD <head> content Mar 19, 2024
@jp-tosca
Copy link
Contributor Author

@pdurbin done 🚀

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
pdurbin
pdurbin reviewed Mar 20, 2024
View reviewed changes
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions for the release note.

doc/release-notes/10382-optional-croissant-exporter.md Outdated Show resolved Hide resolved
@jp-tosca @pdurbin
Update doc/release-notes/10382-optional-croissant-exporter.md
7023fbf 
Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
@github-actions GitHub Actions
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:le-croissant-exportateur

ghcr.io/gdcc/configbaker:le-croissant-exportateur

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

pdurbin
pdurbin approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved.

I've been running this on my dev3 server and it works fine. The only thing to be aware of is that if the Croissant exporter throws an error, the older format (Schema.org JSON-LD) is shown in the <head> instead. I think this is ok.

@pdurbin pdurbin self-assigned this Mar 21, 2024
@pdurbin
Copy link
Member

pdurbin commented Mar 21, 2024

Works great! Merging!

@pdurbin pdurbin merged commit 9e0587f into develop Mar 21, 2024
11 checks passed
@pdurbin pdurbin deleted the le-croissant-exportateur branch March 21, 2024 20:09
@pdurbin pdurbin added this to the 6.2 milestone Mar 21, 2024
@pdurbin pdurbin removed their assignment Mar 21, 2024
@pdurbin pdurbin mentioned this pull request Apr 26, 2024
Merged
This was referenced May 6, 2024
Open
Open
@pdurbin pdurbin mentioned this pull request Jul 19, 2024
Closed
@pdurbin pdurbin mentioned this pull request Aug 22, 2024
Open
@pdurbin pdurbin mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scolapasta scolapasta scolapasta approved these changes

@pdurbin pdurbin pdurbin approved these changes

Assignees
No one assigned
Labels
Feature: Metadata NIH CAFE Issues related to and/or funded by the NIH CAFE project Size: 10 A percentage of a sprint. 7 hours.
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@jp-tosca @coveralls @pdurbin @scolapasta