Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update computational_workflow.tsv #10439

Closed
wants to merge 0 commits into from
Closed

Conversation

kmika11
Copy link
Contributor

@kmika11 kmika11 commented Mar 27, 2024

Add href tag to display url in computational workflow metadata block

What this PR does / why we need it: Adds href tag to the computational workflow tsv file to properly display and link the url required in the External Code Repository URL field.

Which issue(s) this PR closes:

Closes #10339

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here: Makes link clickable on dataset page.

Is there a release notes update needed for this change?:

Additional documentation:

@pdurbin
Copy link
Member

pdurbin commented Mar 27, 2024

@kmika11 thanks for the pull request! I see you used the develop branch. Would it be possible for you to make another PR from a different branch? You could call it "10339-workflow` or whatever. It will make it easier to review and add commits later, per this issue:

Also, I see a lot of whitespace changes. Maybe we can check with @jggautier on what he does but originally we would edit in google spreadsheets and download a .tsv from there. You should be able to use https://docs.google.com/spreadsheets/d/13HP-jI_cwLDHBetn9UKTREPJ_F4iHdAvhjmlvmYdSSw/edit#gid=447508596 as a starting point, I would think. I hope!

@jggautier
Copy link
Contributor

Also, I see a lot of whitespace changes. Maybe we can check with @jggautier on what he does but originally we would edit in google spreadsheets and download a .tsv from there. You should be able to use https://docs.google.com/spreadsheets/d/13HP-jI_cwLDHBetn9UKTREPJ_F4iHdAvhjmlvmYdSSw/edit#gid=447508596 as a starting point, I would think. I hope!

I'm not sure if that works, but worth a try. I don't remember what I usually do, but I've run into this issue with whitespace changes too when the application I'm using to open the tsv files, like excel, adds extra tabs so that each row has the same number of columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Computational Workflow metadata block bug: links don't link
3 participants