-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Handling creation of duplicate role for a dataset object #10474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
pdurbin
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't run the code but it makes sense to me. And there's a test (that's passing). Approved.
luddaniel
pushed a commit
to Recherche-Data-Gouv/dataverse
that referenced
this pull request
Jun 12, 2024
…0474) * 9729: Handling repeated role creation error for datasets * 9729: Fixing unit test * 9729: Optimizing Imports * 9729: Deleting white space * 9729: Deleting redundant line * Update doc/release-notes/9729-release-notes.md Co-authored-by: Philip Durbin <philipdurbin@gmail.com> * 9375: Rolling back wrong code removal and reformatting * 9375: Refactoring and adding test * 9375: Changing message to use property file * 9887: rolling back formatting * 9729: rolling back formatting * 9729: rolling back formatting --------- Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Handles the error properly when trying to create a role already existing for a particular dataset
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Integrations tests
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
no
Additional documentation:
no