Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Handling creation of duplicate role for a dataset object #10474

Merged
merged 13 commits into from
Jun 10, 2024

Conversation

zearaujo25
Copy link
Contributor

@zearaujo25 zearaujo25 commented Apr 9, 2024

What this PR does / why we need it:
Handles the error properly when trying to create a role already existing for a particular dataset

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:
Integrations tests

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
no
Additional documentation:
no

@zearaujo25 zearaujo25 changed the title Fix/9729 API: Handling creation of duplicate role for a dataset object Apr 9, 2024
@zearaujo25 zearaujo25 marked this pull request as ready for review April 9, 2024 23:31
@pdurbin pdurbin added Feature: Permissions Size: 3 A percentage of a sprint. 2.1 hours. labels Apr 10, 2024
@coveralls
Copy link

coveralls commented Apr 19, 2024

Coverage Status

coverage: 20.718% (+0.006%) from 20.712%
when pulling 3c755be on zearaujo25:fix/9729
into 516a73f on IQSS:develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run the code but it makes sense to me. And there's a test (that's passing). Approved.

@stevenwinship stevenwinship self-assigned this Jun 10, 2024
@stevenwinship stevenwinship merged commit 3934c3f into IQSS:develop Jun 10, 2024
11 checks passed
@stevenwinship stevenwinship removed their assignment Jun 10, 2024
@pdurbin pdurbin added this to the 6.3 milestone Jun 10, 2024
luddaniel pushed a commit to Recherche-Data-Gouv/dataverse that referenced this pull request Jun 12, 2024
…0474)

* 9729: Handling repeated role creation error for datasets

* 9729: Fixing unit test

* 9729: Optimizing Imports

* 9729: Deleting white space

* 9729: Deleting redundant line

* Update doc/release-notes/9729-release-notes.md

Co-authored-by: Philip Durbin <philipdurbin@gmail.com>

* 9375: Rolling back wrong code removal and reformatting

* 9375: Refactoring and adding test

* 9375: Changing message to use property file

* 9887: rolling back formatting

* 9729: rolling back formatting

* 9729: rolling back formatting

---------

Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Permissions Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assigning role twice via API causes server error 500
4 participants