Added whitespace trimming to uploaded custom metadata TSV files #10696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erodde thanks for the pull request! Can you please add a release note snippet? Just a single line is fine. Please see https://guides.dataverse.org/en/6.3/developers/version-control.html#writing-release-note-snippets |
Done! |
|
https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10696/2/display/redirect said "not found" so I just merged the latest from develop into this PR to kick off a Jenkins run. |
stevenwinship
approved these changes
Nov 13, 2024
|
Merging PR - Testing Passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
when loading custom metadata blocks using the
api/admin/datasetfield/loadAPI, whitespace can be introduced into field names. The change trims whitespace at the beginning and end of all values read into the API before persisting them. I also added a null check for a potential NPE I found during testing.Which issue(s) this PR closes:
Closes #10688
Special notes for your reviewer:
Suggestions on how to test this:
Load metadata file with whitespace into DV using the API mentioned above.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
I believe not
Additional documentation: